Repository navigation
Fix Reducing-Test-Flakiness.md: promoting a test to prod removes bringup - #192983
Merged
auto-submit[bot] merged 2 commits intoSep 24, 2026
Merged
auto-submit[bot] merged 2 commits into
auto-submit[bot] merged 2 commits into
Conversation
The "enable the test in the prod env" step told readers to "Switch `bringup` to `true`", which is the state the test is already in while in the staging pool. Promoting a target to prod (tree-blocking, presubmit-enabled) means removing `bringup: true` (or setting it to `false`), as described further down in this same document and in flutter/cocoon's CI_YAML.md.
github-actions
Bot
added
team-infra
okorohelijah
marked this pull request as ready for review
September 18, 2026 16:42
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in docs/infra/Reducing-Test-Flakiness.md to clarify how to enable a test in the production environment by removing bringup: true or setting it to false in .ci.yaml, referencing CI_YAML.md. There are no review comments, and I have no feedback to provide.
vashworth
approved these changes
Sep 23, 2026
okorohelijah
added
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/192983, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
okorohelijah
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/infra/Reducing-Test-Flakiness.mddescribes the process for adding a new DeviceLab test: enable it in the staging pool withbringup: true, monitor it, then promote it to prod. The final bullet of that list said:That is the state the target is already in while it is in staging. Promoting a target to prod (tree-blocking, runs in presubmit) means removing
bringup: true(or setting it tofalse). This is what the same document already says further down ("remove thebringup: trueentry for that target"), whatdocs/infra/Adding-a-new-Test-Shard.mdsays, and what the authoritative schema doc in flutter/cocoon says:This PR fixes the single wrong bullet and links to the "Adding new targets" section of CI_YAML.md (the same anchor
Adding-a-new-Test-Shard.mdalready uses).Docs-only change; no behavior or code is affected. No issue is listed as this fixes a trivial (one-line) documentation error, per the template guidance.
Pre-launch Checklist
///). (N/A — markdown docs only.)