Skip to content

Remove doc comment references to GTK C types - #192977

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
szakarias:fix-c-type-doc-references
Sep 22, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
szakarias:fix-c-type-doc-references

Conversation

@szakarias

Copy link
Copy Markdown
Contributor

GObject, GtkWidget, GdkVisual and similar are GTK C types, not Dart elements, so the references in square brackets never resolved. Written as plain text, matching the class doc comments directly above them.

These classes are private and not exported, so the generated documentation is unaffected. Removes 7 comment_references reports.

Towards #192870

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 18, 2026
@github-actions github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation comments in _window_linux.dart by removing square brackets around GObject-related types (such as GObject, GtkContainer, GtkWidget, GdkVisual, GdkScreen, and GdkWindow). I have no feedback to provide.

@szakarias
szakarias requested a review from Piinks September 18, 2026 19:46
@flutter-dashboard

Copy link
Copy Markdown

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #192977 at sha ca525fc

@flutter-dashboard flutter-dashboard Bot added the will affect goldens Changes to golden files label Sep 21, 2026

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2026
@auto-submit

auto-submit Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/192977, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants