Skip to content

[engine] Add cli_util to pubspec.yaml dependency_overrides - #192972

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
kevmoo:engine-cli-util-override
Sep 18, 2026
Merged

[engine] Add cli_util to pubspec.yaml dependency_overrides#192972
auto-submit[bot] merged 1 commit into
flutter:masterfrom
kevmoo:engine-cli-util-override

Conversation

@kevmoo

@kevmoo kevmoo commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Adds cli_util (./third_party/dart/third_party/pkg/tools/pkgs/cli_util) to dependency_overrides in engine/src/flutter/pubspec.yaml.

Dart SDK commit https://dart-review.googlesource.com/c/sdk/+/551940 rolled tools_rev to include dart-lang/tools#2584, which added package:cli_util as a dependency of package:coverage. Because engine/src/flutter/tools/pub_get_offline.py runs dart pub get --offline against engine/src/flutter/pubspec.yaml (_engine_workspace), cli_util must be mapped in dependency_overrides for offline dependency resolution on the Dart-in-Flutter (HHH) builders and the Dart-to-Flutter roll.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 18, 2026
@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Sep 18, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 18, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a dependency override for cli_util pointing to its local path in engine/src/flutter/pubspec.yaml. There are no review comments, and I have no feedback to provide.

@aam

aam commented Sep 18, 2026

Copy link
Copy Markdown
Member

@kevmoo are you landing this to fix the flutter hh
image

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2026
@kevmoo
kevmoo requested review from aam and jason-simmons September 18, 2026 16:27
@kevmoo

kevmoo commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@aam Yes! All checks are green and I added autosubmit — as soon as you LGTM, the bot will merge it and unblock the HHH builders and Dart roll.

@auto-submit
auto-submit Bot added this pull request to the merge queue Sep 18, 2026
@aam

aam commented Sep 18, 2026

Copy link
Copy Markdown
Member

@kevmoo thanks, Nate approved it, so it should land.

I was trying to reproduce this locally but unsuccessfully so far.

@aam

aam commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Was it possible to land this change before landing breaking dart sdk change?

If it was, that would have prevented broken roller and rush to land this after the fact.

@kevmoo

kevmoo commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Was it possible to land this change before landing breaking dart sdk change?

In theory, yes. But I had zero awareness that it would be an issue!

@aam

aam commented Sep 18, 2026

Copy link
Copy Markdown
Member

Was it possible to land this change before landing breaking dart sdk change?

In theory, yes. But I had zero awareness that it would be an issue!

There are flutter try jobs that can be useful in scenarios like this

image

@kevmoo

kevmoo commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@aam good to know! We need a way to run it deterministically, though. I'm not sure I'd KNOW this was needed in this context! (I'll try to remember in the future...)

Merged via the queue into flutter:master with commit e4cb8ff Sep 18, 2026
28 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2026
@kevmoo
kevmoo removed the request for review from jason-simmons September 18, 2026 17:13
@kevmoo
kevmoo deleted the engine-cli-util-override branch September 18, 2026 17:17
This was referenced Sep 18, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 22, 2026
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aam aam aam approved these changes
@biggs0125 biggs0125 biggs0125 approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevmoo @aam @biggs0125