Repository navigation
Manual Roll Dart SDK from 2dfdae0ea100 to 938ec090f8bc (2 revisions) - #192943
Conversation
https://dart.googlesource.com/sdk.git/+log/2dfdae0ea100..938ec090f8bc 2026-09-17 [email protected] Version 3.14.0-239.0.dev 2026-09-17 [email protected] Version 3.14.0-238.0.dev If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the formatting of the cascade block setting styles on rootElement in custom_element_embedding_strategy.dart. The feedback identifies that the inline comment causes the Dart SDK formatter to format the cascade block awkwardly, and suggests ending the cascade early to set touchAction directly on rootElement for better readability.
alexmarkov
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
https://dart.googlesource.com/sdk.git/+log/2dfdae0ea100..938ec090f8bc
2026-09-17 [email protected] Version 3.14.0-239.0.dev
2026-09-17 [email protected] Version 3.14.0-238.0.dev
Reformat engine sources after prebuilt Dart SDK was updated.