[flutter_tools] Fix StateError in testCompilerBuildNativeAssets when package root does not match projectUri by bkonyi · Pull Request #192942 · flutter/flutter

bkonyi · 2026-09-17T18:42:56Z

Fixes a StateError (Bad state: No element) crash in testCompilerBuildNativeAssets when running flutter test in a directory whose URI does not strictly match any package root in package_config.json (such as when working through symlinked project directories, monorepos/workspaces, or ancestor package_config.json files).

Replaces the strict firstWhere((Package p) => p.root == projectUri) lookup with findRunPackageName, which resolves the target package name using the following fallback order:

Direct URI match against projectUri.
Canonicalized filesystem path match (resolving symlinks and trailing slashes).
Matching the project's pubspec.yaml appName in packageConfig.
Returning null if no package can be resolved, logging a warning and skipping native assets hooks gracefully instead of crashing.

Fixes #192933

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

…package root does not match projectUri Avoid throwing an unhandled StateError in testCompilerBuildNativeAssets when no package in buildInfo.packageConfig.packages has a root URI directly matching FlutterProject.current().directory.uri (such as in pub workspaces or symlinked directories). Instead, attempt canonicalized path matching, then fall back to the target package name from the project manifest or packageConfig, and return null gracefully if no package can be resolved. Fixes flutter#192933

…sets Add an optional FileSystem parameter to testCompilerBuildNativeAssets and TestCompilerNativeAssetsBuilderImpl to avoid repeated ambient globals.fs lookups. Decouple _findRunPackageName from FlutterProject by passing projectUri and manifestAppName directly, use fileSystem.path.fromUri instead of allocating a Directory, and add documentation comments.

…derImpl and isolate fallback tier tests

…rNativeAssetsBuilderImpl.build

…assets builder

…CompilerBuildNativeAssets

…d testCompilerBuildNativeAssets

…estCompilerBuildNativeAssets test and document fallback tests

…ativeAssets tests for Windows compatibility

…fine findRunPackageName Tier 3

gemini-code-assist

Code Review

This pull request introduces a robust fallback mechanism (findRunPackageName) for resolving the target package name during native assets builds for tests, handling direct URI matches, canonicalized paths (including symlinks), and project manifest app name fallbacks. It also adds comprehensive unit tests covering these resolution paths and error handling. Feedback suggests optimizing the path resolution logic by checking the manifestAppName first to avoid potentially slow synchronous I/O operations in a loop over all packages.

gemini-code-assist · 2026-10-16T15:42:42Z

+    final Package? pathMatch = packageConfig.packages.where((Package p) {
+      if (!p.root.isScheme(_fileScheme)) {
+        return false;
+      }
+      return _canonicalizeUriPath(fileSystem, p.root) == canonicalProjectDir;
+    }).firstOrNull;
+    if (pathMatch != null) {
+      return pathMatch.name;
+    }


To avoid performing synchronous I/O operations (existsSync and resolveSymbolicLinksSync) in a loop over all packages in packageConfig.packages (which can be slow in large projects), we can add a fast path that checks the package matching manifestAppName first. Since the root package name in package_config.json always matches the name in pubspec.yaml (manifestAppName), this will resolve the package directly in almost all cases without iterating through other packages.

if (manifestAppName.isNotEmpty) { final Package? candidate = packageConfig[manifestAppName]; if (candidate != null && candidate.root.isScheme(_fileScheme) && _canonicalizeUriPath(fileSystem, candidate.root) == canonicalProjectDir) { return candidate.name; } } final Package? pathMatch = packageConfig.packages.where((Package p) { if (!p.root.isScheme(_fileScheme)) { return false; } return _canonicalizeUriPath(fileSystem, p.root) == canonicalProjectDir; }).firstOrNull; if (pathMatch != null) { return pathMatch.name; }

References

Suggest simplification and refactoring: Assess whether the code can be made simpler or refactored to enhance readability and maintainability. ^(link)

dcharkes

IIRC, there are more and older github issues that are related to tool crashes because there are entry points that are not part of the resolved package graph?

LGTM to a sane fallback behavior.

auto-submit · 2026-10-19T15:52:22Z

autosubmit label was removed for flutter/flutter/192942, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

…test

flutteractionsbot · 2026-10-21T15:20:02Z

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

…package root does not match projectUri (flutter#192942) Fixes a `StateError (Bad state: No element)` crash in `testCompilerBuildNativeAssets` when running `flutter test` in a directory whose URI does not strictly match any package root in `package_config.json` (such as when working through symlinked project directories, monorepos/workspaces, or ancestor `package_config.json` files). Replaces the strict `firstWhere((Package p) => p.root == projectUri)` lookup with `findRunPackageName`, which resolves the target package name using the following fallback order: 1. Direct URI match against `projectUri`. 2. Canonicalized filesystem path match (resolving symlinks and trailing slashes). 3. Matching the project's `pubspec.yaml` `appName` in `packageConfig`. 4. Returning `null` if no package can be resolved, logging a warning and skipping native assets hooks gracefully instead of crashing. Fixes flutter#192933 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

bkonyi added the CICD Run CI/CD label Sep 17, 2026

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 17, 2026

bkonyi added 9 commits September 17, 2026 20:16

[flutter_tools] Inject dependencies into TestCompilerNativeAssetsBuil…

aab72ea

…derImpl and isolate fallback tier tests

[flutter_tools] Inline testCompilerBuildNativeAssets into TestCompile…

76c51c6

…rNativeAssetsBuilderImpl.build

[flutter_tools] Revert DI and method-inlining changes in test native …

b3c4302

…assets builder

[flutter_tools] Add explicit types to BuildInfo destructuring in test…

6935711

…CompilerBuildNativeAssets

[flutter_tools] Address code review feedback in findRunPackageName an…

a4897c5

…d testCompilerBuildNativeAssets

[flutter_tools] Exercise real FlutterNativeAssetsBuildRunnerImpl in t…

a29d67a

…estCompilerBuildNativeAssets test and document fallback tests

[flutter_tools] Use host-style MemoryFileSystem in testCompilerBuildN…

e521494

…ativeAssets tests for Windows compatibility

Merge remote-tracking branch 'origin/master' into issue-192933 and re…

0e55e16

…fine findRunPackageName Tier 3

bkonyi requested a review from dcharkes October 16, 2026 15:39

Merge branch 'master' into issue-192933

411cbab

bkonyi marked this pull request as ready for review October 16, 2026 15:39

gemini-code-assist Bot reviewed Oct 16, 2026

View reviewed changes

dcharkes previously approved these changes Oct 19, 2026

View reviewed changes

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 19, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 19, 2026

Fix Windows path resolution for package_config.json in native_assets_…

c8817f2

…test

bkonyi dismissed dcharkes’s stale review via c8817f2 October 19, 2026 17:59

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 19, 2026

bkonyi requested a review from dcharkes October 19, 2026 18:52

dcharkes approved these changes Oct 20, 2026

View reviewed changes

bkonyi added the t: cp-candidate A PR that should be considered for a cherry-pick upon landing. label Oct 20, 2026

auto-submit Bot added this pull request to the merge queue Oct 20, 2026

Merged via the queue into flutter:master with commit 6238260 Oct 20, 2026
28 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2026

engine-flutter-autoroll mentioned this pull request Oct 21, 2026

Roll Flutter from a3d71d82160a to 9fb8bc15b54c (70 revisions) flutter/packages#13361

Closed

bkonyi added cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch labels Oct 21, 2026

bkonyi mentioned this pull request Oct 21, 2026

[stable] [flutter_tools] Fix StateError in testCompilerBuildNativeAssets when package root does not match projectUri #194959

Merged

2 of 5 tasks

Navigation Menu

Repository navigation

[flutter_tools] Fix StateError in testCompilerBuildNativeAssets when package root does not match projectUri - #192942

[flutter_tools] Fix StateError in testCompilerBuildNativeAssets when package root does not match projectUri#192942
auto-submit[bot] merged 12 commits into
flutter:masterfrom
bkonyi:issue-192933

bkonyi commented Sep 17, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Oct 16, 2026

Uh oh!

dcharkes left a comment

Uh oh!

auto-submit Bot commented Oct 19, 2026

Uh oh!

Uh oh!

flutteractionsbot commented Oct 21, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bkonyi commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

dcharkes left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Oct 19, 2026

Uh oh!

Uh oh!

flutteractionsbot commented Oct 21, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bkonyi commented Sep 17, 2026 •

edited

Loading