Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192097
When rasterizing offscreen snapshots through
RenderRepaintBoundary.toImage(),SnapshotControllerImpeller::DoMakeRasterSnapshotpassed/*reset_host_buffer=*/falsetoimpeller::DisplayListToTexture. Because the transient data and index host buffers were never reset upon snapshot completion, each snapshot accumulated vertex and uniform data inHostBufferwhich was never cleaned up.Looking at the history of this file, I don't see anything which suggests a reason why this may have been intentionally set to false, so this PR sets it to true.
I also added a unit test
SnapshotControllerImpeller.MakeImpellerSnapshotSyncRecyclesHostBufferingpu_surface_metal_impeller_unittests.mmthat executes repeated snapshots against a mock delegate and asserts that the total allocated buffer count remains bounded at 1.Pre-launch Checklist
///).