Repository navigation
Update Android plugin language guidance - #192906
Merged
auto-submit[bot] merged 1 commit intoSep 21, 2026
Merged
Conversation
Change the policy for flutter/packages to prefer Kotlin rather than Java for new code, per [RFC 720.0001](https://github.com/flutter/rfc/blob/main/rfc/720.0001-kotlin-in-1p-plugins.md) Part of flutter#188630
github-actions
Bot
added
package
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Android plugin development policy in the documentation to clarify language usage guidelines. The reviewer suggests restructuring the list to better distinguish between non-migration and migration PR requirements for improved logical clarity.
Comment on lines
+257
to
+265
| - Android: Depends on the plugin. For non-migration PRs use: | ||
| - Kotlin if the plugin is already in Kotlin, or for new plugins. | ||
| - Kotlin when adding a new file to a Java or mixed-language plugin, unless there | ||
| are interop issues with existing Java code that make doing so difficult. | ||
| - Kotlin when adding new tests (when feasible). | ||
| - Java when modifying existing Java code. | ||
| - **Note**: Only Flutter team members may migrate an existing plugin's Java code | ||
| to Kotlin, due to the potential difficulty of reviewing such PRs; migration | ||
| PRs from non-team members will be rejected. |
Contributor
There was a problem hiding this comment.
The current structure lists the migration policy note under the bullet point introduced by 'For non-migration PRs use:'. This is logically contradictory. Consider restructuring the list to separate the guidelines for non-migration PRs and migration PRs clearly.
Suggested change
| - Android: Depends on the plugin. For non-migration PRs use: | |
| - Kotlin if the plugin is already in Kotlin, or for new plugins. | |
| - Kotlin when adding a new file to a Java or mixed-language plugin, unless there | |
| are interop issues with existing Java code that make doing so difficult. | |
| - Kotlin when adding new tests (when feasible). | |
| - Java when modifying existing Java code. | |
| - **Note**: Only Flutter team members may migrate an existing plugin's Java code | |
| to Kotlin, due to the potential difficulty of reviewing such PRs; migration | |
| PRs from non-team members will be rejected. | |
| - Android: Depends on the plugin.\n - For non-migration PRs, use:\n - Kotlin if the plugin is already in Kotlin, or for new plugins.\n - Kotlin when adding a new file to a Java or mixed-language plugin, unless there\n are interop issues with existing Java code that make doing so difficult.\n - Kotlin when adding new tests (when feasible).\n - Java when modifying existing Java code.\n - For migration PRs: Only Flutter team members may migrate an existing plugin's Java code\n to Kotlin, due to the potential difficulty of reviewing such PRs; migration\n PRs from non-team members will be rejected. |
Contributor
Author
There was a problem hiding this comment.
This bothered me slightly when writing it, but I didn't (and don't) think it's worth adding nesting to the list just to avoid.
stuartmorgan-g
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the policy for flutter/packages to prefer Kotlin rather than Java for new code, per RFC 720.0001
Part of #188630