Repository navigation
Remove manually-combined darwin/ plugin tests - #192890
Merged
auto-submit[bot] merged 1 commit intoSep 17, 2026
Merged
auto-submit[bot] merged 1 commit into
auto-submit[bot] merged 1 commit into
Conversation
To ensure that `sharedDarwinSource` plugins worked, we had tests that created standard iOS/macOS plugins and then attempted to manually modify them to use `darwin/` and `sharedDarwinSource: true`. However, we now have template options to directly create such plugins, and we are already running tests with them, so we don't need to run the duplicate tests that construct them manually. This both reduces infra time, and avoids the need to maintain project manipulation code that knows the exact source of the template files (which makes updating the code in the templates more difficult).
11 tasks done
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the sharedDarwinSource configuration option and its associated setup logic from the PluginTest class in dev/devicelab/lib/tasks/plugin_tests.dart. Consequently, the helper method convertDefaultPluginToSharedDarwinPlugin and the corresponding integration tests in dev/devicelab/bin/tasks/plugin_test_darwin.dart have been removed. There are no review comments, and I have no feedback to provide.
jmagman
approved these changes
Sep 16, 2026
stuartmorgan-g
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure that
sharedDarwinSourceplugins worked, we had tests that created standard iOS/macOS plugins and then attempted to manually modify them to usedarwin/andsharedDarwinSource: true. However, we now have template options to directly create such plugins, and we are already running tests with them, so we don't need to run the duplicate tests that construct them manually.This both reduces infra time, and avoids the need to maintain project manipulation code that knows the exact source of the template files (which makes updating the code in the templates more difficult).
Helps unblock #63284
Pre-launch Checklist
///).