Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

Roll engine c5a63d2
Roll goldens to 5f172d7c241a8112db53dd9ee3c29a13cf19eb8

@jonahwilliams jonahwilliams changed the title updates for engine roll Roll engine to c5a63d Jul 11, 2018
));

final Set<SemanticsAction> allActions = SemanticsAction.values.values.toSet()
..remove(SemanticsAction.customAction) // customAction is non user-exposed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non --> not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

);

final Set<SemanticsAction> allActions = SemanticsAction.values.values.toSet()
..remove(SemanticsAction.customAction) // customAction is non user-exposed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non --> not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@gspencergoog
Copy link
Contributor

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@jonahwilliams jonahwilliams merged commit 579d2fb into flutter:master Jul 13, 2018
@jonahwilliams jonahwilliams deleted the roll_enginessss branch July 13, 2018 17:35
teriyakijack added a commit to teriyakijack/flutter that referenced this pull request Jul 17, 2018
* flutter_master: (810 commits)
  Revert engine roll to 316b026
  roll engine to 316b026 (flutter#19419)
  Revert "enable lint unnecessary_const (flutter#19342)" (flutter#19423)
  enable lint unnecessary_const (flutter#19342)
  Chevrons in month picker are semi-transparent when the month is scrolled (flutter#19363)
  Revert "Use FlutterProject to locate files  (flutter#18913)" (flutter#19409)
  Extra debug information in run_release_test (flutter#19405)
  Fix typo (flutter#19402)
  Use FlutterProject to locate files  (flutter#18913)
  Revert "roll engine to 9af920e (flutter#19365)" (flutter#19376)
  roll engine to 9af920e (flutter#19365)
  increase cache size if image is loaded that is larger than max size (flutter#19352)
  Add Bash and Zsh command-line completion for flutter (flutter#19243)
  Support keyboardAppearance field for iOS (flutter#19244)
  Add option to silence driver extension errors (flutter#19247)
  Add HeroController to CupertinoApp (flutter#19326)
  have text finder convert Text.rich to plain text for comparison (flutter#19270)
  Correct contentPadding type in InputDecoration.debugFillProperties (flutter#19318)
  Revert "Revert "Use runTests in fuchsia tester. (flutter#19178)" (flutter#19321)" (flutter#19327)
  Roll engine to c5a63d (flutter#19288)
  ...
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request Jul 19, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants