Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again #19277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…19044)" (flutter#19276)" This reverts commit cf93249 as it also includes fix for type error that broke tests.
zanderso
approved these changes
Jul 11, 2018
aam
changed the title
cbracken
approved these changes
Jul 11, 2018
Member
|
May the force be with you. |
aam
force-pushed
the
roll-engine-20180703a
branch
from
fa5b8c1 to
ff6ee9e
Compare
aam
added a commit
to aam/flutter
that referenced
this pull request
Jul 12, 2018
)" This reverts commit 700cb76 as it breaks Windows tests.
aam
added a commit
to aam/flutter
that referenced
this pull request
Jul 12, 2018
…utter#19277)" (flutter#19295)" This reverts commit cc122f1.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
Jul 19, 2018
* Revert "Revert "Roll engine to fed2ea4 (includes dart roll) (flutter#19044)" (flutter#19276)" This reverts commit cf93249 as it also includes fix for type error that broke tests. * Add type cast for dart2 type checks. * Move up to latest goldens * Make inDirectory() type-parameterized. * Add typecasting to transitions_perf_test.dart and microbenchmarks. * Add boolean flag initialization in save_catalog_screenshots.dart * Add type conversion to gallery transition test
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
Jul 19, 2018
)" (flutter#19295) This reverts commit 700cb76 as it breaks Windows tests.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
Jul 19, 2018
…utter#19277)" (flutter#19295)" (flutter#19322) This reverts commit cc122f1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relands #19044 with few fixes:
Changes since last roll: