Repository navigation
Conversation
github-actions
Bot
added
the
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the cross-import of the material package from colors_test.dart by replacing the import of package:flutter/material.dart with package:flutter/painting.dart and removing the MaterialColor swatch comparison test. Consequently, colors_test.dart is removed from the list of known painting cross-imports in check_tests_cross_imports.dart. There are no review comments, and I have no feedback to provide.
This PR ports the Material-specific test from [flutter/flutter#186777](flutter/flutter#186777) to `material_ui`. The `MaterialColor swatch comparison` test verifies equality for separate swatch maps containing the same standard `Color` values. This is a test-only port, so no package version or changelog entry is needed. Part of [flutter/flutter#188444](flutter/flutter#188444). The PR that removes the test in the framework is flutter/flutter#192716
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Updated with latest master to address stale CI configuration and refresh Gold results. Could a maintainer re-add CICD to rerun the tests? |
This PR contains the framework-side remainder of flutter/flutter#186777.
The
MaterialColor swatch comparisontest is ported tomaterial_ui. This PR removes the test frompainting/colors_test.dart, narrows its import frommaterial.darttopainting.dart, and removes the obsolete cross-import allowlist entry.Part of flutter/flutter#188444.