Skip to content

Better Dart bumps - #192644

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
Piinks:bump-dart-tooling
Sep 18, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
Piinks:bump-dart-tooling

Conversation

@Piinks

@Piinks Piinks commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Part of #191628

Adds a script and companion skill for bumping the Dart version in flutter/flutter
Also adds creating an issue to do this every quarter to the quarterly recurring tasks scheduled workflow.

Prior art:

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@Piinks
Piinks requested a review from justinmc September 11, 2026 19:51
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 11, 2026
@github-actions github-actions Bot added team-infra Owned by Infrastructure team d: docs/ flutter/flutter/docs, for contributors labels Sep 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Dart tool script bump_version_constraints.dart and its tests to automate bumping the minimum Dart SDK version constraint across the repository. It also adds a new AI skill definition (SKILL.md) and updates the infrastructure documentation to reference this new tool and workflow. The review feedback suggests adding documentation comments to public members (main and run) in accordance with the style guide, and modifying the script to exit with a non-zero code upon encountering directory traversal errors, along with updating the corresponding tests.

jtmcdole
jtmcdole previously approved these changes Sep 11, 2026
reidbaker
reidbaker previously approved these changes Sep 11, 2026

@reidbaker reidbaker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review the dart code. The rest LGTM

Comment thread .agents/skills/bump-dart/SKILL.md Resolved
Comment thread .agents/skills/bump-dart/SKILL.md Resolved
Comment thread .agents/skills/bump-dart/SKILL.md Resolved
@Piinks
Piinks dismissed stale reviews from reidbaker and jtmcdole via bf3b9da September 17, 2026 20:06
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 17, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Sep 18, 2026
Merged via the queue into flutter:master with commit dd88f10 Sep 18, 2026
22 of 23 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD d: docs/ flutter/flutter/docs, for contributors team-infra Owned by Infrastructure team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants