Repository navigation
Conversation
- Gate ADPF hint session creation to Android 15+ (API 35+). - Dynamically resolve AWorkDuration APIs and APerformanceHint_reportActualWorkDuration2 from libandroid.so. - Report aggregate elapsed duration of CPU build and raster phases (build_ns + raster_ns), work period start timestamp, and total frame duration. - Exclude MergedPlatformUIThread::kMergeAfterLaunch to avoid tracking stale UI thread after dynamic task queue migration. - Manage reusable AWorkDuration instance synchronized under std::mutex with APerformanceHintSession. - Fix target duration state caching to only update upon successful native PowerHAL return. - Apply provisional 75% target frame-work ratio to leave scheduling slack while GPU duration is unmeasured. - De-duplicate updateTargetWorkDuration calls to prevent redundant Binder IPC. - Check NDK return codes, log warnings, and close session cleanly on EPIPE disconnects. - Switch session creation log to FML_DLOG to avoid logcat pollution. - Use explicit types instead of auto per Google C++ style and Flutter reviewer preference.
Member
Author
|
very much a draft, just want to see if tests break |
10 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.