Repository navigation
[flutter_tools] Use super parameters in more places - #192484
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors various command classes in flutter_tools to utilize Dart's super-initializer parameters (super.toolContext), simplifying constructor signatures and removing redundant arguments from super constructor calls. The review feedback suggests further leveraging super parameters for the verboseHelp parameter in BuildIOSSubCommand, BuildMacosCommand, and ChannelCommand to improve code consistency and readability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This is work towards dart-lang/sdk#59226
The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon.
Pre-launch Checklist
///).