Repository navigation
fix some of ignore: avoid_dynamic_calls - #192028
auto-submit[bot] merged 1 commit into
Conversation
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors matrix multiplication in packages/flutter/test/gestures/hit_test_test.dart by replacing the * operator with explicit .multiplied() method calls. This change eliminates the need for // ignore: avoid_dynamic_calls linter annotations. There are no review comments, and I have no additional feedback to provide.
navaronbracke
left a comment
navaronbracke
left a comment
There was a problem hiding this comment.
LGTM, thanks for the cleanup!
Cash or card :-D ? |
navaronbracke
added
the
autosubmit
AbdeMohlbi
removed
the
autosubmit
|
we still need a googler to approve the tests to run on google infra, i did remove autosubmit until then |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
d6cf081 to
30d4540
Compare
Renzo-Olivares
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
as title
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.