Add some violations in a11y inspector by hannah-hyj · Pull Request #191994 · flutter/flutter

hannah-hyj · 2026-08-28T20:35:25Z

Make the traverse function in [_accessibility_evaluations.dart] public.
Add violations in a11y inspector.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request integrates accessibility evaluations into the AccessibilityInspector to append detected accessibility issues, such as tap target size, missing labels, and unlabeled leaf nodes, directly to the JSON representation of semantics nodes. To support this, the traversal methods in several accessibility evaluations were made public. Feedback suggests simplifying the retrieval of the PipelineOwner by utilizing the new _findRenderView helper, which would eliminate the redundant _findPipelineOwner method.

chunhtai · 2026-08-31T18:11:14Z


-  List<Violation> _traverse(SemanticsNode node) {
+  /// Traverses the given [node] and returns all found violations.
+  List<Violation> traverse(SemanticsNode node) {


we should consider move traverse to base class if this is going to be the entry point of evaluation, I originally created evaluate method as entry point to work with bindings, should remove that if that is not useful.

added traverse in the base class

chunhtai · 2026-08-31T18:26:11Z

-      nodes[node.id.toString()] = node.toJson();
+
+      nodes[node.id.toString()] = <String, Object?>{
+        ...node.toJson(),


why expand the map? if we are going to inject other property like issues in line 132, we should probably put node.toJson as a object of its own to avoid property override

sounds good!

chunhtai · 2026-08-31T18:27:09Z

  }

-  // TODO(hannahjin): This returns the first SemanticsOwner of any RenderView.
+  // TODO(hannah-hyj): This returns the first RenderView with a SemanticsOwner.


We should file an issue for this

filed: flutter/devtools#9991

chunhtai

LGTM, except some minor comments

chunhtai · 2026-09-01T19:41:41Z

+  }
+
  /// Evaluate whether the current state of the `binding` conforms to the rule.
  FutureOr<EvaluationResult> evaluate(WidgetsBinding binding) {


if there is practical use case this method, we should remove it

Looks like evaluate(binding) is still necessary because evaluations like MinimumTextContrastEvaluation (which asynchronously rasterizes renderView.debugLayer to check pixel contrast) and TitleEvaluation (which inspects the element tree via binding.rootElement) require WidgetsBinding and cannot be implemented as a synchronous traverse(SemanticsNode)."

Is it possible to have a single entry point for all the guideline? better to keep it unify and abstract.

updated the PR and removed removed traverse() from the Public API, evaluate() will be the single entry point.

chunhtai

my latest comment #191994 (comment)

hannah-hyj · 2026-09-23T18:05:59Z

@chunhtai comment resolved!

chunhtai · 2026-09-23T20:20:47Z

    }

+    // The violations are displayed in Devtool.
+    // TODO(hannah-hyj): If we add a "target platforms" option on the devtool side,


I imagine this should be something set by the devtools instead of hardcoded in framework

yeah that's why I added a TODO here, should pass the target platform from the devtool

chunhtai · 2026-09-23T20:26:58Z

-    expect(labeledResult['result'], isEmpty);
+    final Map<String, Object?> labeledTapTargetResult = await _runEvaluation(
+      tester,
+      <String, String>{'type': 'LabeledTapTargetEvaluation'},


This string should be defined somewhere same for other checks

Added AccessibilityEvaluationType enum and AccessibilityInspectorKeys constants

chunhtai · 2026-09-23T20:28:23Z

+    final nodeIssues = <int, List<Map<String, Object?>>>{};
+
+    final evaluations = <(AccessibilityEvaluation, String)>[
+      (MinimumTapTargetEvaluation(size: minSize), 'tapTargetSize'),


looks like we will have a bunch of strings. We should define them in somewhere and document how each strings are used.

Added AccessibilityEvaluationType enum and AccessibilityInspectorKeys constants

chunhtai · 2026-09-30T19:14:11Z

@@ -62,17 +92,54 @@ class AccessibilityInspector {
  /// Evaluates and returns the semantics tree hierarchy of the application.


We probably shouldn't mixing evaluation result with semantics tree. We may have more guideline later on that doesn't tight to semantics tree. for example the TitleEvaluation

Updated! now it returnes evaluation results under the top-level AccessibilityInspectorKeys.issues key

I meant should we have two endpoints, one for getting semantics tree only, the other for getting violations? The current endpoint, If one only wants to get semantics tree, they will also have to wait for inspection result even if they don't need it.

i worry if there're two endpoints , one for getting semantics tree only, one for getting violations only, they may be called in different frames and the results dont match.
I updated it to two endpoints, but one for getting semantics tree only, one for getting tree and violations, wdyt?

ok that sounds good

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

chunhtai

my latest comment #191994 (comment)

chunhtai

LGTM

Make the traverse function in [_accessibility_evaluations.dart] public. Add violations in a11y inspector. tracking issue: flutter/devtools#9893 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

flutter-dashboard Bot added the CICD Run CI/CD label Aug 28, 2026

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Aug 28, 2026

gemini-code-assist Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/accessibility_inspector.dart Resolved

hannah-hyj requested a review from chunhtai August 28, 2026 20:37

chunhtai reviewed Aug 31, 2026

View reviewed changes

hannah-hyj requested review from chunhtai and victorsanni August 31, 2026 23:28

chunhtai previously approved these changes Sep 1, 2026

View reviewed changes

hannah-hyj dismissed chunhtai’s stale review via 2941209 September 1, 2026 21:22

hannah-hyj force-pushed the add-issues-in-a11y-inspector branch from 2941209 to d0870e6 Compare September 1, 2026 21:23

hannah-hyj requested a review from chunhtai September 1, 2026 21:37

chunhtai reviewed Sep 9, 2026

View reviewed changes

hannah-hyj force-pushed the add-issues-in-a11y-inspector branch from d0870e6 to 174cd00 Compare September 23, 2026 00:25

hannah-hyj requested a review from chunhtai September 23, 2026 00:26

chunhtai reviewed Sep 23, 2026

View reviewed changes

victorsanni removed their request for review September 24, 2026 21:38

hannah-hyj requested a review from chunhtai September 25, 2026 03:39

hannah-hyj force-pushed the add-issues-in-a11y-inspector branch from 5b0c1b0 to df98f5a Compare September 25, 2026 03:59

chunhtai reviewed Sep 30, 2026

View reviewed changes

hannah-hyj requested a review from chunhtai October 1, 2026 19:30

hannah-hyj and others added 8 commits October 1, 2026 13:13

add issues

53daed4

naming

3c9f8ee

update comments

6c86b28

Update packages/flutter/lib/src/widgets/accessibility_inspector.dart

5b816b0

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

updates

1f441d8

resolve comments

75b3c6e

resolve comments

c46452c

only evaluate

81c99ea

chunhtai reviewed Oct 5, 2026

View reviewed changes

hannah-hyj added 2 commits October 6, 2026 13:28

1

38a19a1

_getIssuesAndSemanticsTree

b4844d5

hannah-hyj requested a review from chunhtai October 6, 2026 20:37

chunhtai approved these changes Oct 8, 2026

View reviewed changes

hannah-hyj added this pull request to the merge queue Oct 9, 2026

Merged via the queue into flutter:master with commit 6cfc099 Oct 9, 2026
18 checks passed

hannah-hyj deleted the add-issues-in-a11y-inspector branch October 9, 2026 03:44

justinmc mentioned this pull request Oct 9, 2026

Flutter Notable Commits - 2026 #181433

Open

This was referenced Nov 3, 2026

[a11y] have a way to test that a slider exposes its value #195889

Open

[a11y] have a way to test that images have a text alternative #195890

Open

		@@ -62,17 +92,54 @@ class AccessibilityInspector {
		/// Evaluates and returns the semantics tree hierarchy of the application.

Conversation

hannah-hyj commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

hannah-hyj commented Sep 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hannah-hyj commented Aug 28, 2026 •

edited

Loading

chunhtai Oct 8, 2026 •

edited

Loading