Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the FlutterValidator to resolve symbolic links for the Flutter SDK root directory before checking if the resolved Flutter binary path is within it, falling back to the unresolved path if a FileSystemException occurs. It also adds tests to verify this behavior with symlinked SDKs on Windows and to ensure the validator handles unresolved SDK roots gracefully. There are no review comments, and I have no feedback to provide.
Contributor
|
Hi there! Thanks for your contribution! However, this issue has been resolved on master, so I'm going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Flutter's
FlutterValidatorresolves the executable found onPATH, but previously compared that resolved path with the unresolved Flutter SDK root.On Windows, package managers such as Scoop expose the active SDK through a
currentJunction:current\bin\flutter->3.47.2\bin\flutterBoth paths refer to the same SDK, but
flutter doctorincorrectly reported Flutter and Dart as being outside the current SDK.This change:
FileSystemExceptionwhen the root cannot be resolved and falls back to the existing lexical comparison.Cache.flutterRoot, public APIs, or user-visible logical paths.No screenshots are applicable because this change affects Flutter CLI validation output.
Issues Fixed
Fixes #191936
Testing
flutter test --no-pub test/general.shard/flutter_validator_test.dartfrompackages/flutter_tools— 23 tests passed.flutter analyzefrompackages/flutter_tools— passed.dart format --output=none --set-exit-if-changed— passed.where.exe flutter,where.exe dart, and the patcheddoctor -v.The regression tests cover:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.