Use runTests in fuchsia tester. #19178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
cbracken
approved these changes
Jul 9, 2018
Member
|
|
cbracken
reviewed
Jul 9, 2018
Member
There was a problem hiding this comment.
Optionally you can do the following above, and skip the exit call here.
exitCode = await runTests(...
This allows us to collect code coverage.
tvolkert
reviewed
Jul 9, 2018
Contributor
There was a problem hiding this comment.
Add a TODO to switch to a Fuchsia-specific Artifacts implementation.
added 2 commits
July 9, 2018 14:08
cbracken
approved these changes
Jul 9, 2018
Member
|
Re-LGTM. I'll land once the bots go green. |
zanderso
added a commit
that referenced
this pull request
Jul 12, 2018
tvolkert
pushed a commit
that referenced
this pull request
Jul 13, 2018
teriyakijack
added a commit
to teriyakijack/flutter
that referenced
this pull request
Jul 17, 2018
* flutter_master: (810 commits) Revert engine roll to 316b026 roll engine to 316b026 (flutter#19419) Revert "enable lint unnecessary_const (flutter#19342)" (flutter#19423) enable lint unnecessary_const (flutter#19342) Chevrons in month picker are semi-transparent when the month is scrolled (flutter#19363) Revert "Use FlutterProject to locate files (flutter#18913)" (flutter#19409) Extra debug information in run_release_test (flutter#19405) Fix typo (flutter#19402) Use FlutterProject to locate files (flutter#18913) Revert "roll engine to 9af920e (flutter#19365)" (flutter#19376) roll engine to 9af920e (flutter#19365) increase cache size if image is loaded that is larger than max size (flutter#19352) Add Bash and Zsh command-line completion for flutter (flutter#19243) Support keyboardAppearance field for iOS (flutter#19244) Add option to silence driver extension errors (flutter#19247) Add HeroController to CupertinoApp (flutter#19326) have text finder convert Text.rich to plain text for comparison (flutter#19270) Correct contentPadding type in InputDecoration.debugFillProperties (flutter#19318) Revert "Revert "Use runTests in fuchsia tester. (flutter#19178)" (flutter#19321)" (flutter#19327) Roll engine to c5a63d (flutter#19288) ...
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
Jul 19, 2018
This reverts commit 032f8cd. The test runner hangs on exit after all tests pass when trying to roll this into Fuchsia.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
Jul 19, 2018
…tter#19321)" (flutter#19327) This reverts commit e22f997. Adding the exit(exitCode) fixes the hang. Tested by running `fx run-host-tests` with a topaz checkout. Verified the hang before, no hang after.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to collect code coverage.