Repository navigation
[WebParagraph] Fix text pixelation, glyph clipping, and snapping offsets to avoid subpixel raster caching - #191736
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR improves
WebParagraphtext rendering quality and caching on CanvasKit:FilterQuality.none.g,j,y,_) are no longer clipped at the paint boundary..floor()when generating CSS font strings (cssFontSize.toStringAsFixed(2)), allowing fractional font sizes to render accurately.(0.0, 0.0). As a result, the cached bitmap is valid across all translations and scrolling movements. All complex motion heuristics, frame sequence tracking, settle redraws, and 4-bin quantization state machines have been removed in favor of pure scale-based cache invalidation.Fixes #188323