Repository navigation
[iOS/MacOS] Warn when using deprecated framework build commands - #191644
Merged
auto-submit[bot] merged 12 commits intoOct 23, 2026
Merged
auto-submit[bot] merged 12 commits into
auto-submit[bot] merged 12 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request deprecates the "flutter build ios-framework" and "flutter build macos-framework" commands, replacing them with "flutter build swift-package". It introduces a helper method to print migration warnings and adds corresponding tests. Feedback suggests reordering the new method within the class and adding public-quality documentation (///) to align with the Flutter Style Guide.
vashworth
reviewed
Sep 3, 2026
Co-authored-by: Victoria Ashworth <[email protected]>
… properties Instead of using a custom printMigrationWarning() method, now uses the standard deprecated and deprecationWarning properties from the FlutterCommand base class. This provides a more consistent approach across all deprecated commands and automatically marks the commands as hidden. Changes: - Override deprecated getter to return true in BuildIOSFrameworkCommand and BuildMacOSFrameworkCommand - Override deprecationWarning getter to provide platform-specific migration messages - Remove custom printMigrationWarning() method from BuildFrameworkCommand base class - Remove manual calls to printMigrationWarning() from each command's runCommand() - Update tests to use global logger (set by testUsingContext) for deprecation warning checks - Fix macOS test to use correct platform URL Addresses feedback from vashworth on PR flutter#191644
vashworth
previously approved these changes
Sep 24, 2026
vashworth
requested review from
okorohelijah
and removed request for
hellohuanlin
October 1, 2026 18:25
hellohuanlin
approved these changes
Oct 14, 2026
Contributor
|
autosubmit label was removed for flutter/flutter/191644, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
This was referenced Oct 24, 2026
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
…ter#191644) <!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> Adds migration warnings to the deprecated flutter build ios-framework and flutter build macos-framework commands. It warns users of the replacement flutter build swift-package command and points to [migration documentation](https://docs.flutter.dev/add-to-app/ios/project-setup). Added test + tested locally Screenshots <img width="932" height="186" alt="image" src="https://github.com/user-attachments/assets/40c8d50b-b698-4cfa-896a-722a472db74d" /> <img width="1187" height="261" alt="image" src="https://github.com/user-attachments/assets/66c5e23f-5645-47cf-94ea-906589f31d37" /> Fixes flutter#191367. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Victoria Ashworth <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds migration warnings to the deprecated flutter build ios-framework and flutter build macos-framework commands. It warns users of the replacement flutter build swift-package command and points to migration documentation.
Added test + tested locally
Screenshots


Fixes #191367.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.