Skip to content

chore: correct copy paste error in test name - #191342

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
holzgeist:chore-fix-test-copy-paste-error
Sep 21, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
holzgeist:chore-fix-test-copy-paste-error

Conversation

@holzgeist

Copy link
Copy Markdown
Contributor

Followup to #184961, Gemini found a copy paste when filing the CP PR

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team labels Aug 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a test description in custom_element_dimensions_provider_test.dart from 'limits physical width of element given custom dpr' to 'limits physical height of element given custom dpr'. There are no review comments, and I have no feedback to provide.

@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Sep 18, 2026
@flutter-zl flutter-zl added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Sep 18, 2026
@auto-submit

auto-submit Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/191342, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2026
@flutter-zl
flutter-zl requested a review from mdebbar September 18, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants