Repository navigation
Fix wide gamut condition on metal playground tests - #191210
Merged
auto-submit[bot] merged 1 commit intoAug 17, 2026
Merged
Conversation
github-actions
Bot
added
engine
andywolff
marked this pull request as ready for review
August 17, 2026 17:59
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Metal backend setup in golden_playground_test_mac.cc to only skip wide gamut golden tests if switches.enable_wide_gamut is enabled and the device does not support wide gamut tests. There are no review comments, and I have no feedback to provide.
gaaclarke
approved these changes
Aug 17, 2026
gaaclarke
left a comment
gaaclarke
left a comment
Member
There was a problem hiding this comment.
thanks! fyi we are phasing out support for x64 macs
Contributor
Author
|
Sounds good. Even after we phase out any machines in CI without wide gamut support, is still potentially valuable for the case where someone like me wants to run playground tests locally. Adding autosubmit label |
andywolff
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #191209.
In
golden_playground_test_mac.cc,GoldenPlaygroundTest::SetUp()was unconditionally skipping all Metal and MetalSDF golden tests wheneverDoesSupportWideGamutTests()returnedfalse. On devices without wide gamut support (such asMac_x64CI runners and Intel Macs), this caused standard sRGB golden tests to be skipped.This PR restricts the
DoesSupportWideGamutTests()check to tests that explicitly require wide gamut (switches.enable_wide_gamut), allowing standard sRGB Metal and MetalSDF golden tests to execute.Tested locally on a macOS machine without wide gamut display support. Now only the tests which require wide gamut are skipped, instead of all of them.
Pre-launch Checklist
///).