Skip to content

Remove dead HTMLCanvasElement declaration in packages/flutter - #191165

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
kevmoo:cleanup-flutter-pkg-dead-code
Aug 18, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
kevmoo:cleanup-flutter-pkg-dead-code

Conversation

@kevmoo

@kevmoo kevmoo commented Aug 16, 2026 •

Copy link
Copy Markdown
Contributor

Clean up internal unreferenced HTMLCanvasElement JS interop declaration in packages/flutter/lib/src/web.dart identified during codebase reachability audit.

Pre-launch Checklist

Clean up internal unreferenced symbols identified during codebase audit:
* Remove unused `_PathLineTo` in `packages/flutter/lib/src/material/animated_icons/animated_icons.dart`.
* Remove unused `HTMLCanvasElement` in `packages/flutter/lib/src/web.dart`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is [test-exempt].
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
@github-actions github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 16, 2026
@github-actions

Copy link
Copy Markdown

This pull request contains changes to Material or Cupertino, which are currently frozen in this repository.

Changes should be made in material_ui and/or cupertino_ui in the flutter/packages repository.

Please refer to #188444 for instructions.

@kevmoo kevmoo changed the title Remove dead unreferenced declarations in packages/flutter Remove dead HTMLCanvasElement declaration in packages/flutter Aug 16, 2026
@kevmoo
kevmoo requested a review from harryterkelsen August 16, 2026 05:17

@harryterkelsen harryterkelsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo
kevmoo marked this pull request as ready for review August 18, 2026 07:52
@kevmoo kevmoo added the CICD Run CI/CD label Aug 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the HTMLCanvasElement extension type from packages/flutter/lib/src/web.dart. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants