Repository navigation
[web_ui] Clean up dead unreferenced declarations - #191164
Conversation
Remove dead declarations and unused code identified during reachability audit: - Delete `svg.dart` (legacy HTML debris) - Delete `onscreen_logging.dart` (dead debug helper) - Delete `image_decoding_manager.dart` and its isolated test - Delete unused conversion helpers and CanvasKitError in `canvaskit_api.dart` & `util.dart` - Delete unused DOM wrappers (DomWebSocket, DomMutationObserver, DomFileReader, etc.) and unused HTTP POST helpers in `dom.dart` - Clean up orphaned export directives in `engine.dart`
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up the Flutter Web Engine codebase by removing several unused files, helper functions, and JS interop bindings. Specifically, it deletes the image decoding manager, onscreen logging, and SVG-related utilities, along with their associated tests and exports. It also removes obsolete APIs and DOM bindings from canvaskit_api.dart, util.dart, and dom.dart. I have no feedback to provide as there are no review comments to evaluate.
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/191164, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
@harryterkelsen - i think I need another approval from you! |
flutter-dashboard
Bot
removed
the
autosubmit
Remove dead declarations and unused code identified during reachability audit:
svg.dart(legacy HTML debris)onscreen_logging.dart(dead debug helper)image_decoding_manager.dartand its isolated testcanvaskit_api.dart&util.dartdom.dartengine.dart