Repository navigation
Remove ios_debug_workflow test - #191141
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the ios_debug_workflow task from the devicelab. Specifically, it deletes the dev/devicelab/bin/tasks/ios_debug_workflow.dart test file, removes its entry from TESTOWNERS, and deletes the corresponding Mac_ios ios_debug_workflow target configuration in .ci.yaml. I have no feedback to provide.
jtmcdole
left a comment
jtmcdole
left a comment
There was a problem hiding this comment.
💵 The CodeFu LGTM Note
The LGTM exchange rates are currently trading at:
- 1 LGTM = golden images match closely enough if I squint.
- 2 LGTMs = I checked that this won't break the devicelab benchmarks
- 3 LGTMs = I trust that this C++ pointer won't leak memory every frame.
- 4 LGTMs = CI is green on the first try without a single retry or shard failure
💵 Value officially backed by the full faith, credit, and compute budget of the Flutter EngProd Infrastructure.
Piinks
added
platform-ios
vashworth
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/191141, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
vashworth
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
ios_debug_workflowwas added to test lldb/devicectl workflow back when it was opt-in. It is now enabled by default so we can remove this test.Fixes #191138.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.