Repository navigation
Fix MenuAnchor scrollbar safe area padding - #191085
Closed
abdullahtas0 wants to merge 1 commit into
Closed
abdullahtas0 wants to merge 1 commit into
abdullahtas0 wants to merge 1 commit into
Conversation
|
This pull request contains changes to Material or Cupertino, which are currently frozen in this repository. Changes should be made in Please refer to #188444 for instructions. |
github-actions
Bot
added
framework
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
11 tasks done
Author
|
Superseded by flutter/packages#12470. Material framework changes now need to land in the standalone material_ui package, so I am closing this draft in favor of the packages PR. |
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 22, 2026
Material `Scrollbar` uses the surrounding `MediaQuery.padding` as painter padding when no explicit padding is provided. A `MenuAnchor` overlay is already positioned within the safe area, so inheriting the view padding again shortens the scrollbar track and prevents the thumb from reaching its visual end. This change removes safe-area padding only for the menu's `Scrollbar`, then restores the original `MediaQueryData` below it so custom menu children continue to observe the same media query values as before. It also adds a regression test and a patch changelog entry. Fixes flutter/flutter#188155. This supersedes flutter/flutter#191085, which cannot land in `flutter/flutter` because Material framework changes have moved to `material_ui`. Validation: - The regression test failed before the source change with a 24 logical pixel bottom scrollbar padding and passes after the change. - `flutter test test/menu_anchor_test.dart` (171 passed, 1 skipped) - `flutter analyze --no-pub` - `flutter_plugin_tools format --packages=material_ui` - `flutter_plugin_tools validate --packages=material_ui --check-for-missing-changes` ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MenuAnchor's internalScrollbarinherited the root view'sMediaQuery.padding. On devices with system safe-area padding, this inset the thumb inside the already-positioned menu and prevented it from reaching the end of the menu track.This change removes the view padding for the scrollbar only, while restoring the original
MediaQueryDatafor custom menu content. It also adds a regression test that verifies both behaviors.Fixes #188155.
Pre-launch Checklist
Validation
./bin/flutter test packages/flutter/test/material/menu_anchor_test.dart(171 passed, 1 skipped)./bin/flutter analyze --no-pub packages/flutter(no issues)./bin/dart format packages/flutter/lib/src/material/menu_anchor.dart packages/flutter/test/material/menu_anchor_test.dart(no changes)