Repository navigation
[Android] Only check for user permissions (first two characters) - #191019
Merged
auto-submit[bot] merged 2 commits intoAug 17, 2026
Merged
Conversation
mboetger
requested review from
a team and
camsim99
and removed request for
a team
August 12, 2026 19:23
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the unused fileReadWriteMode constant and simplifies the file access mode checks in build_android_host_app_with_module_aar.dart by verifying if the mode string starts with 'rw' instead of performing an exact platform-specific comparison. There are no review comments, and I have no feedback to provide.
mboetger
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only check the user permissions in dev/devicelab/bin/tasks/build_android_host_app_with_module_aar.dart
Fixes: #190999
Depending on the environment and the umask, different permissions can be given to files during the test run. The files getting executable permission for some reason (rwxr-xr-x) still should pass the test since the user has read/write permissions. The test explicitly wants to check the "user" writable and readable bits - so it only needs to check the first two characters.
Pre-launch Checklist
///).