Repository navigation
Use officially supported compile time thread local strike cache flag. - #191014
auto-submit[bot] merged 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the experimental thread-local strike cache initialization logic and its associated global variable declaration from engine/src/flutter/skwasm/surface.cc. There are no review comments, and I have no feedback to provide.
|
The presubmit tests that check that the concurrency stuff works properly are actually failing, but the tests were suppressed when CI ran. Example failed test: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8673650806783095521/+/u/test:_run_suite_chrome-coi-dart2wasm-skwasm-skwasm/stdout So the flag doesn't seem to be working correctly the way I have it set up. |
eyebrowsoffire
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/191014, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
eyebrowsoffire
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/191014, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
eyebrowsoffire
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
With https://skia-review.git.corp.google.com/c/skia/+/1321976 landing, we have a more officially supported way to opt into thread local strike caches.