Repository navigation
Catch NoSuchFieldError when reading bold text setting on non-compliant vendor runtimes - #190972
Conversation
…mes (flutter#190690) Some vendor-modified runtimes report API 31+ but omit the Configuration.fontWeightAdjustment field. Catch NoSuchFieldError at the Api31Impl call boundary in AccessibilityBridge and fall back to false rather than crashing at startup. Fixes flutter#190690
github-actions
Bot
added
platform-android
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request wraps the bold text detection for API 31 in a try-catch block to handle NoSuchFieldError on vendor-modified runtimes, preventing startup crashes. The reviewer suggests catching LinkageError instead of NoSuchFieldError to ensure robustness against potential class-loading and linking anomalies on non-compliant devices.
…hfielderror' into fix-bold-text-nosuchfielderror
gmackall
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/190972, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Odd, status shows action required even after targets have been re run. I'll just update branch I suppose? |
gmackall
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/190972, because - The status or check suite Mac_arm64_verify_binaries has failed. Please fix the issues identified (or deflake) before re-applying this label. |
gmackall
added
the
autosubmit
let_me_in.gif |
|
autosubmit label was removed for flutter/flutter/190972, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
Bot
removed
the
autosubmit
gmackall
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/190972, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
gmackall
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
Some vendor-modified runtimes report API 31+ but omit the Configuration.fontWeightAdjustment field. Catch NoSuchFieldError at the Api31Impl call boundary in AccessibilityBridge and fall back to false rather than crashing at startup.
Fixes #190690