Repository navigation
[icon_tree_shaker] Tree-shake material and cupertino with 0 icons - #190905
Merged
Merged
Conversation
github-actions
Bot
added
the
tool
dcharkes
marked this pull request as ready for review
August 11, 2026 10:01
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the IconTreeShaker to subset unused known icon fonts (such as MaterialIcons and CupertinoIcons) to a single fallback code point when no icons are recorded, preventing them from being bundled in their entirety. It also adds corresponding tests to verify this behavior. The review feedback suggests optimizing the missingFonts calculation to avoid unnecessary set allocations and refactoring the fallback code point lookup to prevent a double lookup and eliminate a null assertion.
bkonyi
previously approved these changes
Aug 11, 2026
bkonyi
approved these changes
Aug 11, 2026
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
Ensures built-in fonts are tree-shaken if 0 icons are used.