Repository navigation
Revert: Make Xcode workspace cleaning optional during flutter clean - #190890
Conversation
…lutter#190091)" This reverts commit 4e516d7.
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
There was a problem hiding this comment.
Code Review
This pull request removes the --include-xcode-workspace flag from the flutter clean command, making Xcode workspace cleaning the default behavior when Xcode is installed and meets the version check. Error messages, documentation comments, and unit tests have been updated to reflect this change. There are no review comments, so I have no feedback to provide.
Reverts: Make Xcode workspace cleaning optional during flutter clean
Initiated by: @cbracken
Reason for reverting: breaks Mac_arm64 plugin_lint_mac
Original PR Author: @okorohelijah
Reviewed By: @vashworth
The original PR description is provided below:
This PR introduces a new
--include-xcode-workspaceflag to flutter clean which makes Xcode workspace cleaning optional, bypassing the expensive xcodebuild execution that inherently triggers Swift Package resolution over the internet. By default, it will now instantly clean local build directories without polling or cleaning Xcode. Additionally, this updates several Xcode-specific error messages across the codebase to explicitly instruct users to runflutter clean --include-xcode-workspacewhen clearing Xcode's derived data is requiredList which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
Fixes #183946, #173940 and #127708 too
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.