Skip to content

Revert: Make Xcode workspace cleaning optional during flutter clean - #190890

Merged
cbracken merged 1 commit into
flutter:masterfrom
flutteractionsbot:revert-190091-1786413344
Aug 11, 2026
Merged

cbracken merged 1 commit into
flutter:masterfrom
flutteractionsbot:revert-190091-1786413344

Conversation

@flutteractionsbot

Copy link
Copy Markdown
Contributor

Reverts: Make Xcode workspace cleaning optional during flutter clean

Initiated by: @cbracken

Reason for reverting: breaks Mac_arm64 plugin_lint_mac

Original PR Author: @okorohelijah

Reviewed By: @vashworth

The original PR description is provided below:

This PR introduces a new --include-xcode-workspace flag to flutter clean which makes Xcode workspace cleaning optional, bypassing the expensive xcodebuild execution that inherently triggers Swift Package resolution over the internet. By default, it will now instantly clean local build directories without polling or cleaning Xcode. Additionally, this updates several Xcode-specific error messages across the codebase to explicitly instruct users to run flutter clean --include-xcode-workspace when clearing Xcode's derived data is required

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
Fixes #183946, #173940 and #127708 too

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutteractionsbot
flutteractionsbot requested review from a team as code owners August 11, 2026 01:55
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 11, 2026
@github-actions github-actions Bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. platform-macos Building on or for macOS specifically a: desktop Running on desktop team-ios Owned by iOS platform team team-macos Owned by the macOS platform team labels Aug 11, 2026
@cbracken cbracken added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Aug 11, 2026
@flutter-dashboard

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the --include-xcode-workspace flag from the flutter clean command, making Xcode workspace cleaning the default behavior when Xcode is installed and meets the version check. Error messages, documentation comments, and unit tests have been updated to reflect this change. There are no review comments, so I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop CICD Run CI/CD emergency Jump the queue; land PR in front of all others; only use for emergencies platform-ios iOS applications specifically platform-macos Building on or for macOS specifically team-ios Owned by iOS platform team team-macos Owned by the macOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SwiftPM regresses flutter clean times

2 participants