Repository navigation
Fix web tracing flakiness on macOS ARM64 - #190759
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Chrome tracing configuration to use traceConfig with thread CPU time enabled, and introduces support for the wall-clock duration field dur in BlinkTraceEvent as a fallback when tdur is missing. Feedback suggests refactoring the duration calculation in _computeAverageDuration to assign the value to a local variable first, leveraging Dart's type promotion to avoid using the null-assertion operator (!).
harryterkelsen
added
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/190759, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
harryterkelsen
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This PR fixes a source of flakiness in the devicelab
runWebBenchmarktask, particularly on macOS ARM64 machines. The issue occurs when thetdur(thread CPU duration) field is missing from a Chrome trace event, causing the benchmark harness to throw aFormatException.Changes in this PR:
Tracing.startChrome DevTools Protocol call from using the deprecatedcategoriesargument to the moderntraceConfigobject, explicitly passingenableThreadCpuTime: true. This ensures Chrome makes its best effort to capture thread durations.dur) when calculating average frame times iftduris still unavailable (which happens occasionally due to sandbox/OS limitations blocking Mach thread API calls on macOS).Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.