Repository navigation
Conversation
Clarify the behavior of the Divider color property in Material 3. Fixes: #190534
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the Divider class to clarify how the divider color is determined when Material 3 is enabled. The review feedback suggests improving the documentation style for consistency, specifically by properly formatting references to [ThemeData.useMaterial3] and using the more idiomatic [ColorScheme.outlineVariant] reference.
| /// also null, then [ThemeData.dividerColor] is used. | ||
| /// also null, then [ThemeData.dividerColor] is used when | ||
| /// [ThemeData.useMaterial3] is false and [ColorScheme.outlineVariant] | ||
| /// is used when [ThemeData.useMaterial3] is true. |
There was a problem hiding this comment.
LGTM, but could we change the order here (i.e. list useMaterial3 is true case first since that is the default)?
|
Please fix: |
elliette
added
the
waiting for response
|
This PR is ready to port to flutter/packages! 🥳 |
dkwingsmt
added
the
Decoupling: Port to flutter/packages
|
This pull request is being closed because it has not been updated in the last 21 days after a request for more information. If you are still working on this, please feel free to reopen it or file a new pull request. Thanks for your contribution. |
Clarify the behavior of the Divider color property in Material 3.
Fixes: #190534
This is only updating the documentation on
Divider.colorto match the actual behaviour.Pre-launch Checklist
///).