Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) #19044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
#19008 contains a competing engine roll. |
Member
Author
|
Non-fatal error is generated when flutter is being built: cc @a-siva in case you have some thoughts on this |
Member
Author
|
@devoncarew have you had much progress with running flutter tools in dart2 mode? @a-siva mentioned you were looking at that recently. The issues we are seeing here seem to be related to that. |
Contributor
|
I have a PR that address some issues: #19007 If this is blocking the roll I can look at addressing the review comments and seeing about landing it. |
Member
Author
|
Okay, good to know. We could run flutter tools explictly in dart1 mode until your PR lands |
Contributor
Sounds like a good workaround; we would want to back out that flag and see what the impact is. |
Member
Author
I gave it a try (add |
Contributor
|
Will land my PR once the bots are device bots are green.
Note that I had once small update - changes that hadn't made it into the main PR the first time around. |
Member
Author
Yep, github pinged me when you added another change. |
aam
force-pushed
the
roll-engine-20180703
branch
3 times, most recently
from
31fa065 to
9b6a079
Compare
Member
Author
|
flutter_tools tests are failing with mysterious error: cc @a-siva |
dart-bot
referenced
this pull request
in dart-lang/sdk
Jul 4, 2018
bin/util.dart doesn't have main() entry point and that breaks snapshot generation that is automatically invoked by pub for all dart sources in bin/ folder. See https://github.com/flutter/flutter/pull/19044\#issuecomment-402241782 Change-Id: Ie91549173536740992ce61d830efdfdc603c5564 Reviewed-on: https://dart-review.googlesource.com/63683 Commit-Queue: Alexander Aprelev <[email protected]> Reviewed-by: Alexander Markov <[email protected]>
aam
force-pushed
the
roll-engine-20180703
branch
11 times, most recently
from
e7463ed to
7e29a6b
Compare
aam
force-pushed
the
roll-engine-20180703
branch
from
108f268 to
4b9a66a
Compare
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Jul 10, 2018
* ensure a11y state is communicated back to flutter (flutter/engine#5631) * Roll src/third_party/skia b1b87d9df81e..a1e5630183c1 (10 commits) (flutter/engine#5637) * Roll src/third_party/skia 385804514edf..b1b87d9df81e (6 commits) (flutter/engine#5636) * Roll src/third_party/skia e97bb26893a1..385804514edf (1 commits) (flutter/engine#5635) * Roll src/third_party/skia e2e52e46ca63..e97bb26893a1 (1 commits) (flutter/engine#5634) * Roll src/third_party/skia 14de25dfc7c4..e2e52e46ca63 (2 commits) (flutter/engine#5633) * Roll src/third_party/skia 551dc3e91143..14de25dfc7c4 (2 commits) (flutter/engine#5630) * libtxt: apply an offset to drawing operations instead of translating the canvas (flutter/engine#5628) * Roll src/third_party/skia 059a9ab4bcd0..551dc3e91143 (5 commits) (flutter/engine#5629) * Roll src/third_party/skia 45c9dab4c3ec..059a9ab4bcd0 (8 commits) (flutter/engine#5627) * Remove some unused code from the Android host (flutter/engine#5619) * Roll src/third_party/skia 37b7e4714558..45c9dab4c3ec (1 commits) (flutter/engine#5626) * Roll src/third_party/skia c421ca1d6e41..37b7e4714558 (2 commits) (flutter/engine#5624) * Roll src/third_party/skia 5b201e3b0ba8..c421ca1d6e41 (3 commits) (flutter/engine#5623) * Roll src/third_party/skia d47fe095cf88..5b201e3b0ba8 (6 commits) (flutter/engine#5622) * Roll src/third_party/skia 9c0ce41cf711..d47fe095cf88 (12 commits) (flutter/engine#5618 * Roll src/third_party/skia d4b2adeaa929..9c0ce41cf711 (7 commits) (flutter/engine#5617) * Roll src/third_party/skia f46710802ad5..d4b2adeaa929 (1 commits) (flutter/engine#5616) Also update goldens to 2694735bcfe755238f42da1be9a472e6795c9bdd * Update goldens for flutter#19044 (flutter/goldens#6)
aam
force-pushed
the
roll-engine-20180703
branch
from
4b9a66a to
8c75c22
Compare
Add connectionTimeout property to class that extends HttpOverrides. Upgrade packages. Add more type fixes. Update goldens hash. Add more type fixes. Upgrade packages. Fix tests. Remove strong-mode from analysis options yaml file. Increase dev/devicelab timeout from 2 to 10 seconds. Added getVM to waitForViews. Fix type errors in compileExpression.
aam
force-pushed
the
roll-engine-20180703
branch
from
8c75c22 to
029bf69
Compare
aam
changed the title
aam
force-pushed
the
roll-engine-20180703
branch
3 times, most recently
from
45a56d2 to
8495c76
Compare
Increase default timeout from 20/30 to 60s.
aam
force-pushed
the
roll-engine-20180703
branch
from
8495c76 to
8aa5114
Compare
Member
|
FYI I have an engine roll almost about to land... |
Member
Author
|
@cbracken wrote:
Not sure how we ended up with competing rolls, but I see yours still have errors, which I believe mine have fixes for. |
Member
|
sgtm! |
aam
added a commit
to aam/flutter
that referenced
this pull request
Jul 11, 2018
This reverts commit f4a038d as it breaks microbenchmark tests.
aam
added a commit
that referenced
this pull request
Jul 11, 2018
This reverts commit f4a038d as it breaks microbenchmark tests.
aam
added a commit
to aam/flutter
that referenced
this pull request
Jul 11, 2018
…19044)" (flutter#19276)" This reverts commit cf93249 as it also includes fix for type error that broke tests.
aam
added a commit
that referenced
this pull request
Jul 12, 2018
* Revert "Revert "Roll engine to fed2ea4 (includes dart roll) (#19044)" (#19276)" This reverts commit cf93249 as it also includes fix for type error that broke tests. * Add type cast for dart2 type checks. * Move up to latest goldens * Make inDirectory() type-parameterized. * Add typecasting to transitions_perf_test.dart and microbenchmarks. * Add boolean flag initialization in save_catalog_screenshots.dart * Add type conversion to gallery transition test
jacob314
pushed a commit
to jacob314/flutter
that referenced
this pull request
Jul 16, 2018
…19044)" (flutter#19276)" This reverts commit cf93249 as it also includes fix for type error that broke tests.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
Jul 19, 2018
…lutter#19276) This reverts commit f4a038d as it breaks microbenchmark tests.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
Jul 19, 2018
* Revert "Revert "Roll engine to fed2ea4 (includes dart roll) (flutter#19044)" (flutter#19276)" This reverts commit cf93249 as it also includes fix for type error that broke tests. * Add type cast for dart2 type checks. * Move up to latest goldens * Make inDirectory() type-parameterized. * Add typecasting to transitions_perf_test.dart and microbenchmarks. * Add boolean flag initialization in save_catalog_screenshots.dart * Add type conversion to gallery transition test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes since last roll: