Repository navigation
[CP-beta] Remove ancient tools:tools dep from android_sdk bundle - #190182
auto-submit[bot] merged 2 commits into
Conversation
…89962) This dep has been abandoned https://developer.android.com/tools/releases/sdk-tools Also bumps to include sdk 37, because the underlying script had been bumped without a corresponding bump in the ci.yaml
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to beta. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
There was a problem hiding this comment.
Code Review
This pull request updates the android_sdk dependency version to 37v2 across multiple targets in .ci.yaml, updates the Android lint baseline configuration, and removes the tools:tools package from packages.txt. Additionally, it cleans up daemon_test.dart by removing an unused import and re-enabling the emulator.getEmulators test on macOS. No review comments were provided, and there is no feedback to address.
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
tools:tools dep from android_sdk bundle (#189962)tools:tools dep from android_sdk bundle (#189962)
tools:tools dep from android_sdk bundle (#189962)tools:tools dep from android_sdk bundle
|
Hey we dont merge directly into the beta branch. We merge into the flutter candidate branch that is used to then publish (aka force push beta) |
|
That said the rest of the pr looks reasonable. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
tools:tools dep from android_sdk bundletools:tools dep from android_sdk bundle
tools:tools dep from android_sdk bundletools:tools dep from android_sdk bundle
eb61588
into
flutter:flutter-3.47-candidate.0
|
cc @LongCatIsLooong should be part of 3.47.0-0.4.pre Beta |
This dep has been abandoned
https://developer.android.com/tools/releases/sdk-tools
Also bumps to include sdk 37, because the underlying script had been bumped without a corresponding bump in the ci.yaml
This is a cherry-pick of #189962 to
betabranch to ensure tests pass for builds/releases on the beta branch.Impacted Users: Flutter releng / CI infra team. No direct end-user or app-developer impact. This affects the ability to produce beta/release builds on the arm64 Mac CI bot pool.
Impact Description: The android_sdk CIPD bundle pulls in the ancient, abandoned tools:tools package, whose emulator binary is Intel-only and requires Rosetta to run. We're removing Rosetta from the arm64 Mac CI bot pool, so any CI step that touches that binary will fail on those machines. Without this, we can't remove Rosetta from the prod/dart-internal.flutter bot pools. No impact on flutter apps.
Workaround: The only alternatives are to keep Rosetta installed on the arm64 Mac bots.
Risk: Low. The removed tools:tools package has been abandoned by Android and is not used by the build; the change swaps to the already-published android_sdk version:37v2 CIPD bundle and re-enables a test that was only skipped because of the Intel-only binary. Changes are confined to CI/dependency configuration, the lint baseline, and a single test.
Test Coverage: Yes. The change re-enables the emulator.getEmulators should respond with list daemon test on macOS (previously skipped via #189876), and the existing Android/CI test shards exercise the updated SDK bundle. The commit landed and passed on master as #189962.
Validation Steps:
Issue: #189876
Issue: #103386
Fixes: #190176 (cherry-pick issue)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.