Skip to content

Conversation

@abarth
Copy link
Contributor

@abarth abarth commented Feb 15, 2016

This patch teaches the flutter command to download the Dart SDK into
cache, removing another step from the Getting Started workflow. The
version of the Dart SDK is controlled by the "dart-sdk.version" file in
the bin/cache directory.

Fixes #54

@abarth
Copy link
Contributor Author

abarth commented Feb 15, 2016

@abarth
Copy link
Contributor Author

abarth commented Feb 15, 2016

@tvolkert

@abarth
Copy link
Contributor Author

abarth commented Feb 15, 2016

@sethladd

This patch teaches the flutter command to download the Dart SDK into
cache, removing another step from the Getting Started workflow. The
version of the Dart SDK is controlled by the "dart-sdk.version" file in
the bin/cache directory.

Fixes flutter#54
@chinmaygarde
Copy link
Member

lgtm

@eseidelGoogle
Copy link
Contributor

lgtm. We can also now remove infra/download_dart_sdk.py (after updating
the bots of course).

On Mon, Feb 15, 2016 at 12:21 AM, Chinmay Garde [email protected]
wrote:

lgtm


Reply to this email directly or view it on GitHub
#1895 (comment).

@Hixie
Copy link
Contributor

Hixie commented Feb 15, 2016

landing this to test it

Hixie added a commit that referenced this pull request Feb 15, 2016
Internalize our dependency on the Dart SDK
@Hixie Hixie merged commit a85e770 into flutter:master Feb 15, 2016
TahaTesser pushed a commit to NevercodeHQ/flutter that referenced this pull request Aug 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download the Dart SDK automatically

4 participants