Fix TestSemantics typo bugs (self-comparisons and stray assert comma)#189480
Draft
hkarmoush wants to merge 2 commits into
Draft
Fix TestSemantics typo bugs (self-comparisons and stray assert comma)#189480hkarmoush wants to merge 2 commits into
hkarmoush wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Fixes three copy/paste typos that silently disabled checks in the `TestSemantics`/`SemanticsTester` test helpers, in both the widgets and material copies: 1. `_stringAttributesEqual` compared a `LocaleStringAttribute`'s locale to itself (`second[i]` vs `second[i]`), so mismatched locales were treated as equal. It now compares `first[i]` against `second[i]`. 2. The `controlsNodes` check guarded on `controlsNodes != controlsNodes` (always false), so the check never ran. It now guards on `controlsNodes != null`, matching the pattern used by every other nullable field. 3. A stray comma in the `_IncludesNodeWith` assert pushed `minValue`/`maxValue` into the message argument instead of the condition. They are now part of the `||` condition. Adds a regression test verifying that `SemanticsTester.nodesWith` distinguishes `LocaleStringAttribute`s by locale. Fixes flutter#185900
hkarmoush
force-pushed
the
fix/185900-testsemantics-typos
branch
from
July 14, 2026 23:19
a6a3af1 to
3d3ee75
Compare
github-actions
Bot
added
framework
hkarmoush
force-pushed
the
fix/185900-testsemantics-typos
branch
from
July 15, 2026 11:48
3d3ee75 to
7e2adfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three copy/paste typos that silently disabled checks in the
TestSemantics/SemanticsTestertest helpers, in both the widgets and material copies:_stringAttributesEqualcompared aLocaleStringAttribute's locale to itself (second[i]vssecond[i]), so mismatched locales were treated as equal. It now comparesfirst[i]againstsecond[i].controlsNodescheck guarded oncontrolsNodes != controlsNodes(always false), so the check never ran. It now guards oncontrolsNodes != null, matching the pattern used by every other nullable field._IncludesNodeWithassert pushedminValue/maxValueinto the message argument instead of the condition. They are now part of the||condition.Adds a regression test verifying that
SemanticsTester.nodesWithdistinguishesLocaleStringAttributes by locale.Fixes #185900
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.