Disable some Windows tests that are flaking on CI#189477
Merged
auto-submit[bot] merged 2 commits intoJul 15, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables the TooltipWindowUpdatesPositionOnViewSizeChange and PopupWindowUpdatesPositionOnViewSizeChange unit tests on Windows. The feedback recommends adding TODO comments with links to tracking issues for both disabled tests to ensure they are addressed in the future.
Comment on lines
+628
to
+629
| TEST_F(WindowManagerTest, | ||
| DISABLED_TooltipWindowUpdatesPositionOnViewSizeChange) { |
Contributor
There was a problem hiding this comment.
When disabling a test, it is best practice to add a TODO comment referencing the tracking issue. This ensures the test is not permanently forgotten and provides context on why it was disabled.
Suggested change
| TEST_F(WindowManagerTest, | |
| DISABLED_TooltipWindowUpdatesPositionOnViewSizeChange) { | |
| // TODO(https://github.com/flutter/flutter/issues/177172): Flaky on Windows. | |
| TEST_F(WindowManagerTest, | |
| DISABLED_TooltipWindowUpdatesPositionOnViewSizeChange) { |
References
- Documentation should be useful: Explain the why and the how. (link)
Member
There was a problem hiding this comment.
Suggested change
| TEST_F(WindowManagerTest, | |
| DISABLED_TooltipWindowUpdatesPositionOnViewSizeChange) { | |
| // TODO(team-windows): Flaky: | |
| // https://github.com/flutter/flutter/issues/177172 | |
| TEST_F(WindowManagerTest, | |
| DISABLED_TooltipWindowUpdatesPositionOnViewSizeChange) { |
| } | ||
|
|
||
| TEST_F(WindowManagerTest, PopupWindowUpdatesPositionOnViewSizeChange) { | ||
| TEST_F(WindowManagerTest, DISABLED_PopupWindowUpdatesPositionOnViewSizeChange) { |
Contributor
There was a problem hiding this comment.
When disabling a test, it is best practice to add a TODO comment referencing the tracking issue. This ensures the test is not permanently forgotten and provides context on why it was disabled.
Suggested change
| TEST_F(WindowManagerTest, DISABLED_PopupWindowUpdatesPositionOnViewSizeChange) { | |
| // TODO(https://github.com/flutter/flutter/issues/177172): Flaky on Windows. | |
| TEST_F(WindowManagerTest, DISABLED_PopupWindowUpdatesPositionOnViewSizeChange) { |
References
- Documentation should be useful: Explain the why and the how. (link)
Member
There was a problem hiding this comment.
Or alternative:
Suggested change
| TEST_F(WindowManagerTest, DISABLED_PopupWindowUpdatesPositionOnViewSizeChange) { | |
| // TODO(team-windows): Flaky. See: | |
| // https://github.com/flutter/flutter/issues/177172 | |
| TEST_F(WindowManagerTest, DISABLED_PopupWindowUpdatesPositionOnViewSizeChange) { |
loic-sharma
previously approved these changes
Jul 14, 2026
loic-sharma
left a comment
loic-sharma
left a comment
Member
There was a problem hiding this comment.
LGTM, but please add links to the tracking issue so that it's easier to remember why we had to disable these tests :)
loic-sharma
approved these changes
Jul 14, 2026
jason-simmons
added
the
autosubmit
github-actions
Bot
added
engine
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/189477, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jason-simmons
added
the
autosubmit
jtmcdole
approved these changes
Jul 15, 2026
flutter-dashboard
Bot
removed
the
autosubmit
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 15, 2026
flutter/flutter@846664b...fc1ad95 2026-07-15 [email protected] [iOS] Migrate FlutterKeyboardInsetManager to Swift (flutter/flutter#189425) 2026-07-15 [email protected] Roll Dart SDK from 05bf153370c4 to 0c408ff6dce9 (4 revisions) (flutter/flutter#189487) 2026-07-15 [email protected] Implement UberSDF lines to replace LineContents-based AA lines (flutter/flutter#188514) 2026-07-15 [email protected] Fix stale eagerWinner reference in GestureArenaManager when rejected before arena close (flutter/flutter#187008) 2026-07-15 [email protected] Disable some Windows tests that are flaking on CI (flutter/flutter#189477) 2026-07-15 dmgr Added unified check-run user manual (flutter/flutter#189453) 2026-07-15 [email protected] Roll Skia from 88954ef8f36d to ab2410bc857c (9 revisions) (flutter/flutter#189474) 2026-07-14 [email protected] [agents] Refactor shepherd-prs skill into a pure Markdown runbook using native gh CLI (flutter/flutter#189095) 2026-07-14 [email protected] Add missing name to mirroring workflow (flutter/flutter#189439) 2026-07-14 [email protected] Add support for WASM deferred loading. (flutter/flutter#189308) 2026-07-14 [email protected] fix `templateDefaultGradleVersion` todo (flutter/flutter#189466) 2026-07-14 [email protected] Roll Fuchsia Linux SDK from oOETA0ISPouDt2xBo... to lLFbh5kFWbUGgC9Ek... (flutter/flutter#189469) 2026-07-14 [email protected] Use ServicesBinding.instance.exitApplication instead of exit(0) in multiple_windows example (flutter/flutter#189364) 2026-07-14 [email protected] Add CpuArch to the Device class (flutter/flutter#189207) 2026-07-14 [email protected] Fix space formatting in cherry-pick label for flutter_cp.dart (flutter/flutter#189463) 2026-07-14 [email protected] Roll pub packages (flutter/flutter#189454) 2026-07-14 [email protected] [flutter_tools] Format plugin example template to match dart format (flutter/flutter#188382) 2026-07-14 [email protected] Move renamed x64->ARM benchmarks out of bringup (flutter/flutter#189400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #177172