Skip to content

Run Mac golden tests on ARM bots#189465

Open
jmagman wants to merge 4 commits into
flutter:masterfrom
jmagman:golden-arm
Open

Run Mac golden tests on ARM bots#189465
jmagman wants to merge 4 commits into
flutter:masterfrom
jmagman:golden-arm

Conversation

@jmagman

@jmagman jmagman commented Jul 14, 2026

Copy link
Copy Markdown
Member

Intel bots are being deprecated. Pin the builds that generate goldens to ARM instead of Intel (see #119880). This PR indeed generated new goldens as described in #119880.

  • Mac framework_tests_libraries
  • Mac framework_tests_impeller
  • Mac framework_tests_widgets

Fixes #119880
Part of #189144

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@jmagman jmagman added the CICD Run CI/CD label Jul 14, 2026
@jmagman
jmagman marked this pull request as ready for review July 14, 2026 22:40

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CPU property from x86 to arm64 for three targets using the flutter/flutter_drone recipe in .ci.yaml. There are no review comments, and I have no feedback to provide.

@jmagman
jmagman requested review from gaaclarke and justinmc July 14, 2026 22:41
@flutter-dashboard

Copy link
Copy Markdown

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #189465 at sha c679a43

@flutter-dashboard flutter-dashboard Bot added the will affect goldens Changes to golden files label Jul 14, 2026
@jmagman jmagman added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. labels Jul 16, 2026

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i overlooked the golden changes and the all look fine to me too.

@github-actions github-actions Bot removed framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. labels Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running Mac framework_tests* on arm64 Macs flakes with "Skia Gold received an unapproved image in post-submit"

2 participants