Skip to content

Update Depdencies Used By flutter_engine_group_performance#189229

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jesswrd:fix-broken-tree
Jul 10, 2026
Merged

Update Depdencies Used By flutter_engine_group_performance#189229
auto-submit[bot] merged 1 commit into
flutter:masterfrom
jesswrd:fix-broken-tree

Conversation

@jesswrd

@jesswrd jesswrd commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

I raised the warn and error version in this PR: #189109. The dependencies used by flutter_engine_group_performance were not updated as a part of that PR. I missed that update earlier, and I'm guessing that flutter_engine_group_performance is post-submit test.

Fixes #189228
Related to: #189383

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kotlin, Android Gradle Plugin (AGP), and Gradle wrapper versions for the multiple_flutters benchmark. However, the specified versions (Kotlin 2.2.20, AGP 8.11.1, and Gradle 8.14) do not exist, which will lead to build failures. Please update these to valid, stable versions as suggested.

Comment thread dev/benchmarks/multiple_flutters/android/build.gradle
Comment thread dev/benchmarks/multiple_flutters/android/build.gradle
@cbracken cbracken added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Jul 10, 2026
@flutter-dashboard

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Jul 10, 2026
Merged via the queue into flutter:master with commit 1d5bcf3 Jul 10, 2026
193 of 194 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jul 10, 2026
flutter/flutter@dc2a870...f7b66f3

2026-07-10 [email protected] [iOS][test] Fix VSyncClient display link deallocation test on iOS 27 (flutter/flutter#188627)
2026-07-10 [email protected] Fix broken listener code in WindowScope (flutter/flutter#189208)
2026-07-10 [email protected] [web] Preserve text field focus across tab switches (flutter/flutter#188738)
2026-07-10 [email protected] [Impeller] Recycle HostBuffer arena entries only after GPU completion (flutter/flutter#188965)
2026-07-10 [email protected] Assert TextStyle height is not NaN (flutter/flutter#186617)
2026-07-10 [email protected] Roll Fuchsia Test Scripts from dFkTCiDxEtPxYK5Nn... to wLST_A-xfOeGT_5mj... (flutter/flutter#189259)
2026-07-10 [email protected] Roll Dart SDK from a11fb7ed40a5 to 0fc1668c4af4 (5 revisions) (flutter/flutter#189257)
2026-07-10 [email protected] Adds a missing `await` to a `FutureOr` (flutter/flutter#189198)
2026-07-10 [email protected] [web] Repair RenderCanvas CSS size drift (flutter/flutter#188797)
2026-07-10 [email protected] Roll Fuchsia Test Scripts from s5_gZFJ8De9AJalTw... to dFkTCiDxEtPxYK5Nn... (flutter/flutter#189215)
2026-07-10 [email protected] Roll Fuchsia Linux SDK from QcRFUtvCw2EobfJ8s... to czpzDg9ABY2oKLAOY... (flutter/flutter#189222)
2026-07-10 [email protected] Update Depdencies Used By `flutter_engine_group_performance` (flutter/flutter#189229)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jesswrd added a commit to jesswrd/flutter that referenced this pull request Jul 14, 2026
…#189229)

I raised the warn and error version in this PR:
flutter#189109. The dependencies used by
`flutter_engine_group_performance` were not updated as a part of that
PR. I missed that update earlier, and I'm guessing that
`flutter_engine_group_performance` is post-submit test.

Fixes flutter#189228 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
auto-submit Bot pushed a commit that referenced this pull request Jul 21, 2026
This was a manual cherry pick of #189109 and of #189229.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

#189228

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

This affects all Flutter Android apps and add-to-app integrations below the new warn and error version thresholds. Apps below the warn version will successfully build with warning logs urging an upgrade. Apps below the error version will fail to build and receive logs to upgrade.

New Warn Version
AGP: 9.0.1
Gradle: 9.1.0
KGP: 2.3.20

New Error Version
AGP: 8.11.1
Gradle: 8.14
KGP: 2.2.20

### Changelog Description:
Explain this cherry pick:
* In one line that is accessible to most Flutter developers.
* That describes the state prior to the fix.
* That includes which platforms are impacted.
See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples.

< Replace with changelog description here >
[flutter/189383](#186100): When building Flutter Android apps and add-to-app modules using AGP < 9, the tool does not prompt developers to upgrade to AGP 9+ or log Built-in Kotlin migration warnings.

### Workaround:
Is there a workaround for this issue?

This change must be made. More develoeprs should upgrade to AGP 9+ to receive Built-in Kotlin migration warnings. To urge more developers to migrate to AGP 9+, we must raise the warn version to AGP 9+ to urge a larger chunk of our developers to migrate to AGP 9+. This must be done in this release because we don't have many Flutter releases left before AGP 10 releases.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?
To validate the new warn version:
- `flutter create` a new app
- change versions to just below the warn version AGP: 9.0.1, Gradle: 9.1.0 KGP: 2.3.20 in settings.gradle.kts
- `flutter build apk` and the build is successful but you will see logs urging you to upgrade.
- change versions to the warn version GP: 9.0.1, Gradle: 9.1.0 KGP: 2.3.20 in settings.gradle.kts
-`flutter build apk` and the build is successful and you will see no logs

To validate the new error version:
- change versions to just below the error version AGP: 8.11.1, Gradle: 8.14 KGP: 2.2.20 in settings.gradle.kts
- `flutter build apk` and the build will fail and you will see logs urging you to upgrade.
- change versions to the error version  AGP: 8.11.1, Gradle: 8.14 KGP: 2.2.20 in settings.gradle.kts
-`flutter build apk` and the build is successful and you will see no logs

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD emergency Jump the queue; land PR in front of all others; only use for emergencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux_mokey flutter_engine_group_performance failures breaking tree

2 participants