Skip to content

Stop using ReLinker to load libflutter.so on Android 17 (API 37+)#189146

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
gmackall:skip-relinker-on-api-37
Jul 21, 2026
Merged

Stop using ReLinker to load libflutter.so on Android 17 (API 37+)#189146
auto-submit[bot] merged 5 commits into
flutter:masterfrom
gmackall:skip-relinker-on-api-37

Conversation

@gmackall

@gmackall gmackall commented Jul 8, 2026

Copy link
Copy Markdown
Member

ReLinker's fallback sets the extracted library owner-writable (setWritable(true)) and then System.loads it, which Android 17 Safer DCL rejects. Because of this ReLinker is incompatible with the safer dynamic code loading requirements introduced in Android 17 (API 37): libraries loaded via System.load() must be read-only. On API 37+ load libflutter.so with the platform loader (System.loadLibrary) directly, gated on the io.flutter.Build.API_LEVELS.API_37 constant.

ReLinker's fallback path copies the native library out of the APK and
modifies its file permissions, which is incompatible with the safer
dynamic code loading requirements introduced in Android 17 (API 37):
libraries loaded via System.load() must be read-only. On API 37+ load
libflutter.so with the platform loader (System.loadLibrary) directly,
gated on the io.flutter.Build.API_LEVELS.API_37 constant.

See flutter#184861
@github-actions github-actions Bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Jul 8, 2026
@gmackall gmackall added the CICD Run CI/CD label Jul 8, 2026
@gmackall
gmackall marked this pull request as ready for review July 8, 2026 20:30
@gmackall
gmackall requested a review from a team as a code owner July 8, 2026 20:30
@gmackall
gmackall requested review from reidbaker and removed request for a team July 8, 2026 20:30

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates FlutterJNI to load the Flutter library using the system linker on Android API 37 and above, while continuing to use ReLinker on older versions. It also adds corresponding unit tests. Feedback highlights that modifying Build.VERSION.SDK_INT via reflection in the unit tests can persist across tests in the same Robolectric sandbox, potentially causing test pollution. It is recommended to capture and restore the original SDK version in a finally block.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 20, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 20, 2026
@auto-submit

auto-submit Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/189146, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@auto-submit

auto-submit Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/189146, because - The status or check suite Windows tool_integration_tests_1_10 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 20, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Jul 20, 2026
Merged via the queue into flutter:master with commit 02fe54a Jul 21, 2026
19 of 20 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jul 21, 2026
flutter/flutter@cab057d...1ac2e82

2026-07-21 [email protected] Add BaseWindowController.isDestroyed flag (flutter/flutter#189061)
2026-07-21 [email protected] Roll Dart SDK from 666e1e2133b7 to 3b2f5ad7718d (1 revision) (flutter/flutter#189745)
2026-07-21 [email protected] Roll Skia from 3c52d80c960d to 569534e9fa59 (5 revisions) (flutter/flutter#189766)
2026-07-21 [email protected] Roll Skia from 11426cf7aaa1 to 3c52d80c960d (2 revisions) (flutter/flutter#189758)
2026-07-21 [email protected] Roll pub packages (flutter/flutter#189760)
2026-07-21 [email protected] [iOS] Inject DisplayLinkManager into FlutterKeyboardInsetManager (flutter/flutter#189751)
2026-07-21 [email protected] Treat package:stack_trace async-gap marker as asynchronous suspension (flutter/flutter#185791)
2026-07-21 [email protected] [iOS] Inject DisplayLinkManager into VsyncWaiterIOS (flutter/flutter#189749)
2026-07-20 [email protected] Use String builder in `InputConnectionAdaptorTest.java` (flutter/flutter#189281)
2026-07-20 [email protected] Fix non-independant tests in draggable_test.dart (flutter/flutter#186898)
2026-07-20 [email protected] Stop using ReLinker to load libflutter.so on Android 17 (API 37+) (flutter/flutter#189146)
2026-07-20 [email protected] [et] Refactor gn post-processing, fix minor clang[++] regex match bug (flutter/flutter#189685)
2026-07-20 [email protected] Take plugin_test_darwin out of bringup (flutter/flutter#189594)
2026-07-20 [email protected] Roll pub packages (flutter/flutter#189596)
2026-07-20 [email protected] widgets layer re-export ScrollCacheExtent (flutter/flutter#189483)
2026-07-20 [email protected] Roll Skia from 47143b6fa402 to 11426cf7aaa1 (7 revisions) (flutter/flutter#189740)
2026-07-20 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#189735)
2026-07-20 [email protected] [Impeller] In the AHBTextureSourceVK destructor, do not call Vulkan APIs if the VkDevice has been destroyed (flutter/flutter#189666)
2026-07-20 [email protected] Add AutofillHints.emailOTPCode for Android AUTOFILL_HINT_EMAIL_OTP (flutter/flutter#188123)
2026-07-20 [email protected] Add a github workflow to remove flutteractionsbot branches after the PRs are merged or closed. (flutter/flutter#189668)
2026-07-20 [email protected] Roll ANGLE to cc08479fbcc1 (flutter/flutter#189595)
2026-07-20 [email protected] Roll Fuchsia Linux SDK from NL8xtzr8cxr5E8r8E... to GswhlPRO-D1qSNclx... (flutter/flutter#189715)
2026-07-20 [email protected] Roll Skia from ba90f98535de to 47143b6fa402 (4 revisions) (flutter/flutter#189721)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-android Android applications specifically team-android Owned by Android platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants