Code Review

This pull request introduces caching and reuse of the FlutterEngine for the Vulkan backend in MainActivity to prevent teardown crashes and speed up test execution, along with corresponding cleanup in FlutterActivityTest. Feedback on these changes highlights potential memory leaks: a static reference to FlutterEngine should be wrapped in a WeakReference, and the MethodCallHandler registered on the cached engine should be cleared in cleanUpFlutterEngine to avoid capturing destroyed activity instances. Additionally, a more idiomatic Kotlin implementation is suggested for the engine caching logic.

Addressed all comments in 0b80f70

Code Review

This pull request implements caching for the FlutterEngine on the Vulkan backend in MainActivity to avoid teardown crashes, along with associated cleanup in FlutterActivityTest and checks to prevent duplicate view factory registration. The review feedback identifies a potential memory leak in MainActivity.kt caused by passing an Activity context to the globally cached FlutterEngine, and suggests using the application context instead.

Code Review

This pull request introduces engine caching for the Vulkan backend in the Android hardware smoke test to improve performance and prevent teardown crashes. It adds a tearDownClass method to the test suite and updates MainActivity to manage engine lifecycle, including tracking the last configured engine and cleaning up method channel handlers. Feedback was provided regarding the potential for memory leaks when reusing the NativeTextViewFactory and the incorrect approach to clearing method channel handlers in cleanUpFlutterEngine.

Code Review

This pull request introduces caching of the FlutterEngine for the Vulkan backend in MainActivity to prevent teardown crashes and speed up test execution, along with corresponding cleanup in FlutterActivityTest. The review feedback recommends tracking the active activity instance via a static reference to prevent a race condition during activity transitions, which could otherwise cause a destroying activity to prematurely clear the method call handlers of a newly created activity on the shared cached engine.

Code Review

This pull request implements Flutter engine caching for the Vulkan backend in the Android hardware smoke test to prevent teardown crashes and optimize test execution. It introduces a teardown mechanism in the test class and manages activity transition states in MainActivity using weak references. The review feedback suggests optimizing the retrieval of the Impeller backend to avoid duplicate expensive PackageManager metadata queries, and performing subclass-specific cleanup in cleanUpFlutterEngine before calling the superclass method.

Code Review

This pull request introduces Flutter engine caching for the Vulkan backend in MainActivity to prevent teardown crashes and optimize test execution, alongside proper cleanup handling in both MainActivity and FlutterActivityTest. The review feedback suggests exposing the cached engine key constant as internal from MainActivity and referencing it in the test class to avoid duplicating the string literal.

LGTM