Skip to content

[CP-beta] Ensure Warnings Do Not Log When AGP Is Below 9#188720

Merged
auto-submit[bot] merged 1 commit into
flutter:flutter-3.46-candidate.0from
jesswrd:cp-beta-dont-log
Jun 30, 2026
Merged

[CP-beta] Ensure Warnings Do Not Log When AGP Is Below 9#188720
auto-submit[bot] merged 1 commit into
flutter:flutter-3.46-candidate.0from
jesswrd:cp-beta-dont-log

Conversation

@jesswrd

@jesswrd jesswrd commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

This was a manual cherry pick of #188373.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#188718

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

All existing Flutter Android apps and add-to-app scenarios that use AGP < 9 and apply KGP.

Changelog Description:

Explain this cherry pick:

  • In one line that is accessible to most Flutter developers.
  • That describes the state prior to the fix.
  • That includes which platforms are impacted.
    See best practices for examples.

< Replace with changelog description here >
flutter/188718: When building Flutter Android apps and add-to-app modules using AGP < 9 with KGP, the tool incorrectly logs Built-in Kotlin migration warnings.

Workaround:

Is there a workaround for this issue?

This change must be made. Built-in Kotlin only exists starting AGP 9, therefore we should not be informing app developers to migrate when their apps are below AGP 9.

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

  • navigate to plugin camera_android_camerax in the packages repo
  • change versions to AGP: 8.11.1, Gradle: 8.14, KGP: 2.2.20 in settings.gradle.kts
  • add KGP id("kotlin-android") to the example app build.gradle.kts and the plugin module's build.gradle.kts
  • flutter build apk and the build is successful and you see no logs. Without this change, you will see logs both for app developers and for plugin authors.

Warnings to migrate to built-in kotlin should not log when AGP is below
9. This should be CP'ed to the current stable and beta. This is an
effort to split this large PR:
flutter#187534 (comment)

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@jesswrd
jesswrd requested a review from a team as a code owner June 29, 2026 08:17
@jesswrd
jesswrd requested review from mboetger and removed request for a team June 29, 2026 08:17
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 29, 2026
@github-actions github-actions Bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. team-android Owned by Android platform team labels Jun 29, 2026
@jesswrd jesswrd changed the title [AGP 9] Ensure Warnings Do Not Log When AGP Is Below 9 (#188373) [CP-beta] Ensure Warnings Do Not Log When AGP Is Below 9 (#188373) Jun 29, 2026
@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the detectApplyingKotlinGradlePlugin tests in FlutterPluginUtilsTest.kt by introducing helper classes SubprojectConfig and TestEnvironment to reduce boilerplate, and updates FlutterPluginUtils.kt to safely query the AGP version after projects are evaluated. Feedback on the changes includes removing an unused and conflicting import of kotlin.test.assertTrue, avoiding potential IndexOutOfBoundsException from hardcoded list indices in TestEnvironment, and correcting a typo in a comment.

@jesswrd jesswrd changed the title [CP-beta] Ensure Warnings Do Not Log When AGP Is Below 9 (#188373) [CP-beta] Ensure Warnings Do Not Log When AGP Is Below 9 Jun 29, 2026
@jesswrd
jesswrd requested review from reidbaker and removed request for mboetger June 29, 2026 08:28
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2026
@auto-submit
auto-submit Bot merged commit 165f945 into flutter:flutter-3.46-candidate.0 Jun 30, 2026
154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD platform-android Android applications specifically team-android Owned by Android platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants