Skip to content

fix(ci): download correct engine artifacts for tree-analyze on engine PR - #188650

Merged
auto-submit[bot] merged 3 commits into
masterfrom
tree_analyze
Jun 26, 2026
Merged

auto-submit[bot] merged 3 commits into
masterfrom
tree_analyze

Conversation

@jtmcdole

@jtmcdole jtmcdole commented Jun 26, 2026 •

Copy link
Copy Markdown
Member

The tree-analyze workflow was previously failing on Engine PRs because the flutter tool would fall back to downloading engine artifacts using a generated content hash. By explicitly setting FLUTTER_PREBUILT_ENGINE_VERSION to the PR's head SHA, the tool now correctly downloads the artifacts generated by the Linux linux_host_engine check

Proof this works: https://github.com/flutter/flutter/actions/runs/28265264690/job/83750315664?pr=188650

The tree-analyze workflow was previously failing on Engine PRs because the
flutter tool would fall back to downloading engine artifacts using a
generated content hash. By explicitly setting FLUTTER_PREBUILT_ENGINE_VERSION
to the PR's head SHA, the tool now correctly downloads the artifacts
generated by the Linux linux_host_engine check

(Includes a temporary DO_NOT_SUBMIT.md file to trigger an engine build for testing.)
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 26, 2026
@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Jun 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new file engine/src/DO_NOT_SUBMIT.md containing a single line of text to test engine builds. There are no review comments, and I have no feedback to provide.

@github-actions github-actions Bot removed the engine flutter/engine related. See also e: labels. label Jun 26, 2026
@jtmcdole
jtmcdole requested a review from eyebrowsoffire June 26, 2026 21:40
@jtmcdole

Copy link
Copy Markdown
Member Author

fyi: @jmagman / @zanderso - woohoo!

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Jun 26, 2026
@jtmcdole

jtmcdole commented Jun 26, 2026 •

Copy link
Copy Markdown
Member Author

fixes #188046
fixes #187817

Merged via the queue into master with commit 990e440 Jun 26, 2026
25 checks passed
@auto-submit
auto-submit Bot deleted the tree_analyze branch June 26, 2026 22:30
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants