Skip to content

[web] Record end-to-end presentation duration in benchmarks - #188628

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
MarlonJD:skwasm-safari-retained-presentation
Oct 30, 2026
Merged

auto-submit[bot] merged 5 commits into
flutter:masterfrom
MarlonJD:skwasm-safari-retained-presentation

Conversation

@MarlonJD

@MarlonJD MarlonJD commented Jun 26, 2026 •

Copy link
Copy Markdown
Contributor

Related: #187660. Part 1 of 5 from the original hybrid-rasterizer change. This PR is now limited to the independent benchmark instrumentation.

Adds presentation_duration around preparation and frame submission, including asynchronous raster work, and records it in the web benchmark harness. The timer stops before reporting, and benchmark listeners are cleaned up even when startup fails. The existing profile JSON schema is unchanged.

Verified locally: two engine timing tests cover enabled/disabled profiling and delayed preparation/rasterization; a browser regression test covers listener cleanup after synchronous startup failures. Static analysis and formatting pass. This change is independent of the hybrid rasterizer.

The remaining pieces are separate drafts:

The duplicate semaphore and codec changes were dropped on rebase because master already includes #194139 and #193187.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@MichealReed

Copy link
Copy Markdown
Contributor

@MarlonJD I'm eager to use FLUTTER_WEB_SKWASM_FORCE_MULTI_SURFACE_RASTERIZER, will this PR be re-opened?

@MarlonJD MarlonJD reopened this Sep 15, 2026
@fluttergithubbot

Copy link
Copy Markdown
Contributor

An existing Git SHA, 2edd50a01813cdb588d219b71eb0baf7b567f569, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@MarlonJD

Copy link
Copy Markdown
Contributor Author

@MichealReed Yes, I've reopened it as a draft and updated the branch against master. The benchmarks show lower raster times on desktop Safari, a physical iPhone, and Firefox. Chrome improved in two workloads, with mixed card-scrolling results. I've added the results to the PR description.

@MichealReed

Copy link
Copy Markdown
Contributor

@MarlonJD do you agree this would fix #192784?

@MarlonJD

Copy link
Copy Markdown
Contributor Author

@MichealReed I tested the attached repro on macOS Chrome 152 against this branch. In both single- and multi-threaded mode, the default path gave the primary canvas the popup's dimensions in all 120 samples; with skwasmForceMultiSurfaceRasterizer: true, both views kept their own dimensions in all 120 samples. So it addresses the backing-size race when enabled. The default path is still affected, and I haven't verified Windows yet.

@MichealReed

Copy link
Copy Markdown
Contributor

@MarlonJD this is still marked as a draft. What do you think is remaining for the flutter team to review?

@MarlonJD
MarlonJD marked this pull request as ready for review September 15, 2026 20:18

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for forcing a multi-surface rasterizer in Skwasm when the browser supports transferring canvas control to an offscreen canvas, or when running in single-threaded mode. It updates SkwasmSurface to implement OnscreenSurface, handles CSS-only resizing for transferred canvases, and adds comprehensive tests. Feedback on the changes suggests resolving a potential DOM leak by clearing _hostElement before appending a new canvas, improving type safety during canvas resizing, removing an unnecessary async keyword from SkwasmRenderer.initialize, and explicitly using pictures_pointer.get() in the C++ surface worker to avoid compiler warnings.

Comment on lines +156 to +161
void _maybeAttachCanvasToDom() {
if (_isOnscreen) {
_hostElement.appendChild(_canvas as DomHTMLCanvasElement);
_applyOverlayPositioning();
}
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

When recreating the WebGL context (e.g., after a context loss event), recreateContextForCanvas is called, which updates _canvas and calls _maybeAttachCanvasToDom(). However, the old canvas element is never removed from _hostElement before the new one is appended. This will cause multiple canvas elements to accumulate inside _hostElement, leading to DOM leaks and potential rendering/clipping bugs.\n\nPlease clear any existing children from _hostElement before appending the new canvas.

  void _maybeAttachCanvasToDom() {\n    if (_isOnscreen) {\n      while (_hostElement.firstChild != null) {\n        _hostElement.removeChild(_hostElement.firstChild!);\n      }\n      _hostElement.appendChild(_canvas as DomHTMLCanvasElement);\n      _applyOverlayPositioning();\n    }\n  }

Comment on lines +316 to +318
} else {
_canvasProvider.resizeCanvas(_canvas, size);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and type safety, we should cast _canvasProvider to OnscreenCanvasProvider and pass the already-cast canvas variable (which is statically typed as DomHTMLCanvasElement) instead of _canvas (which is typed as DomEventTarget). This avoids relying on implicit downcasting or generic covariance at runtime.

      } else {\n        (_canvasProvider as OnscreenCanvasProvider).resizeCanvas(canvas, size);\n      }
References
  1. Optimize for readability: Code is read more often than it is written. (link)

Comment on lines 318 to 321
FutureOr<void> initialize() async {
rasterizer = _createRasterizer(isMultiThreaded: isMultiThreaded);
return super.initialize();
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The initialize method does not use await anywhere in its body. Marking it as async unnecessarily wraps the returned FutureOr<void> in a Future, which can introduce microtask delays and overhead on a performance-critical initialization path.

  @override\n  FutureOr<void> initialize() {\n    rasterizer = _createRasterizer(isMultiThreaded: isMultiThreaded);\n    return super.initialize();\n  }
References
  1. Suggest simplification and refactoring: Assess whether the code can be made simpler or refactored to enhance readability and maintainability. (link)

Comment thread engine/src/flutter/skwasm/surface.cc Outdated
Comment on lines +484 to +487
std::unique_ptr<sk_sp<flutter::DisplayList>[]> pictures_pointer =
std::unique_ptr<sk_sp<flutter::DisplayList>[]>(pictures);
surface->RenderPicturesOnWorker(pictures, picture_count, callback_id,
raster_start);
raster_start, capture_image_bitmaps);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid potential compiler warnings about pictures_pointer being an unused variable (since it is only declared to manage lifetime via RAII), we should pass pictures_pointer.get() to RenderPicturesOnWorker instead of the raw pictures parameter. This makes the usage of the smart pointer explicit.

  std::unique_ptr<sk_sp<flutter::DisplayList>[]> pictures_pointer =\n      std::unique_ptr<sk_sp<flutter::DisplayList>[]>(pictures);\n  surface->RenderPicturesOnWorker(pictures_pointer.get(), picture_count, callback_id,\n                                  raster_start, capture_image_bitmaps);

@MichealReed

Copy link
Copy Markdown
Contributor

@kevmoo @harryterkelsen could you guys review when you get the chance please?

@flutter-zl flutter-zl added the CICD Run CI/CD label Sep 23, 2026
@harryterkelsen

Copy link
Copy Markdown
Contributor

A few high-level comments before taking a deep look into this PR:

  • We want to move away from MultiSurfaceRasterizer in both renderers once Firefox and Safari have better/faster support for transferToImageBitmap, that's why we didn't invest in implementing MultiSurfaceRasterizer in Skwasm. MultiSurfaceRasterizer has some downsides such as an upper bound on the total number of WebGL contexts as well as it being unclear where some GL resources live (e.g. if you create an image and upload the texture, you only upload it to one WebGL context, if the image needs to be rendered in a different Surface, you will hit bugs).
  • I wonder how much of the performance gains are from MultiSurfaceRasterizer and how much are from transferControlToOffscreen. If there is only one canvas, maybe we can always use transferControlToOffscreen and have these performance gains without needing MultiSurfaceRasterizer in Skwasm?

Thanks for your PR. Let's discuss this some more so we can decide on next steps.

@MarlonJD

@harryterkelsen harryterkelsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment above

@MarlonJD

MarlonJD commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

I tested a single-canvas prototype on an M2 Pro Mac. Multithreaded presentation time in milliseconds, using the median of three run means:

Browser Benchmark ImageBitmap baseline Single-canvas prototype Current PR
Safari Card scroll 3.09 0.92 0.93
Safari Text scroll 2.43 1.34 1.42
Firefox Card scroll 9.85 1.29 1.25
Firefox Text scroll 9.83 1.64 1.63

All 10 focused correctness tests passed across four configurations covering Safari, Firefox, and Chrome. The prototype currently covers only single-canvas rendering; transitions to additional canvases or views still need work.

Would you prefer this PR to optimize single-canvas presentation while preserving existing rendering for multi-canvas and multi-view cases, or should improving those cases also be in scope?

@harryterkelsen

Copy link
Copy Markdown
Contributor

Those are some very exciting numbers! I think it's definitely worth trying to get transferControlToOffscreen working in the single-canvas case given the clear performance improvements. It looks like transferControlToOffscreen is more optimized across the major browsers than createImageBitmap. My main concern with this approach is:

What should we do when we go from one Surface to multiple? For example, if a platform view is rendered and we need an overlay canvas. We need to make sure there's no jank or white flashes if we go from a transferControlToOffscreen Surface to multiple bitmaprenderer canvases. A pie-in-the-sky idea is that we can always use one Surface even when there are platform views if we use the HTML-in-Canvas proposal.

But, if the transition from one Surface to multiple is seamless (and the transition from multiple Surfaces back to only one), then I think this seems like a slam dunk.

@MarlonJD

MarlonJD commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @harryterkelsen Agreed, the results suggest that transferControlToOffscreen is where most of the performance gain comes from.

I’ll explore a hybrid approach that uses the transferred canvas for single-canvas rendering and falls back to the existing bitmaprenderer path when multiple surfaces are needed.

The main challenge is keeping the previous frame visible until the new rendering path is ready. I’ll focus on making that transition seamless in both directions and testing it across Safari, Firefox, and Chrome.

I’ll share the results before making larger changes to the PR.

@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Oct 13, 2026
@MarlonJD

Copy link
Copy Markdown
Contributor Author

Thanks @harryterkelsen. The revised implementation uses transferControlToOffscreen for single-canvas scenes and bitmap composition for overlays or multiple views. Skwasm no longer selects MultiSurfaceRasterizer.

Both transition directions retain the visible frame until the next presentation is ready; bitmap → direct also requires an independent pixel comparison. Local validation passes 318 tests across Chrome/Safari/Firefox and Wimp ST/MT, with two known Wimp shader skips (#175431). Compositor recordings at 75% CSS display scale pass 60 Hz scene-marker checks over 288 directional transitions and 48 resized exits.

A Wasm Workers semaphore fix addresses the reproduced FreeType corruption and native stall, with a regression test. The original Safari hang was unsymbolized, so its attribution remains probable.

The paired benchmarks below show lower median presentation time in all tested cases. Defaults remain hybrid for desktop WebKit/Firefox and Chromium ST; Chromium MT and mobile remain opt-in. The measured single-view case uses two presentation contexts instead of one. Total GPU memory and context-limit stress remain unmeasured.

HTML-in-Canvas remains a separate proposal; this change retains DOM platform views. Mobile checks have not been repeated with the native fix, and fresh upstream CI is pending.

Full desktop benchmarks — 72 runs across 12 cases

Apple M2 Pro Mac mini, macOS 27, DPR 2. Safari 27.0, Chrome 155.0.8059.40, Firefox 148.0. Both paths use the same source-built release engine with the semaphore fix. Each run has 200 warm-up samples and 100 measured samples: 7,200 measured samples overall.

All values are presentation time in milliseconds; lower is better. Each run column lists three run means. The comparison uses their median, and percentage change is (hybrid / bitmap − 1) × 100. Values are rounded for display. ST means single-threaded; MT means multi-threaded.

Safari

Threads Workload Bitmap runs 1 / 2 / 3 Hybrid runs 1 / 2 / 3 Median bitmap → hybrid Change
ST Cards 1.609 / 1.558 / 1.603 0.556 / 0.558 / 0.449 1.603 → 0.556 -65.3%
ST Text 1.839 / 1.897 / 1.922 1.175 / 1.174 / 1.111 1.897 → 1.174 -38.1%
MT Cards 3.359 / 3.148 / 3.195 0.829 / 0.877 / 0.907 3.195 → 0.877 -72.5%
MT Text 2.192 / 2.372 / 2.300 1.246 / 1.318 / 1.332 2.300 → 1.318 -42.7%

Chrome

Threads Workload Bitmap runs 1 / 2 / 3 Hybrid runs 1 / 2 / 3 Median bitmap → hybrid Change
ST Cards 0.719 / 0.698 / 0.302 0.263 / 0.262 / 0.813 0.698 → 0.263 -62.4%
ST Text 2.355 / 2.288 / 0.725 2.073 / 2.110 / 1.136 2.288 → 2.073 -9.4%
MT Cards 1.523 / 1.232 / 1.396 1.300 / 1.044 / 1.093 1.396 → 1.093 -21.7%
MT Text 2.572 / 2.297 / 1.369 1.119 / 1.371 / 1.985 2.297 → 1.371 -40.3%

Firefox

Threads Workload Bitmap runs 1 / 2 / 3 Hybrid runs 1 / 2 / 3 Median bitmap → hybrid Change
ST Cards 9.456 / 9.620 / 9.643 0.902 / 1.025 / 0.882 9.620 → 0.902 -90.6%
ST Text 9.773 / 9.787 / 9.719 1.808 / 1.695 / 1.758 9.773 → 1.758 -82.0%
MT Cards 9.971 / 10.040 / 10.197 1.200 / 1.138 / 0.931 10.040 → 1.138 -88.7%
MT Text 9.766 / 9.732 / 9.927 3.675 / 1.263 / 1.370 9.766 → 1.370 -86.0%

Cards: bench_card_infinite_scroll. Text: bench_simple_lazy_text_scroll.

These are local presentation-time measurements, not FPS or physical display latency, and they do not isolate the semaphore fix’s performance effect. Three repeats show substantial variation in some Chrome cases; the medians are descriptive, not a statistical significance claim. Chromium MT stays opt-in because earlier results were mixed; these desktop numbers do not qualify mobile performance.

@auto-submit

auto-submit Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/188628, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@harryterkelsen harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2026
@auto-submit

auto-submit Bot commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/188628, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

mdebbar
mdebbar previously approved these changes Oct 26, 2026
@MarlonJD
MarlonJD dismissed stale reviews from mdebbar and harryterkelsen via a057851 October 26, 2026 18:54
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Oct 26, 2026
@harryterkelsen harryterkelsen added the CICD Run CI/CD label Oct 26, 2026
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2026
@flutter-dashboard

Copy link
Copy Markdown

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: 45d8126.

Possible causes:

  • Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
  • Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

FormatException: ERROR: Mac_ios new_gallery_skia_ios__transition_perf is a new builder added. it needs to be marked bringup: true
If ci.yaml wasn't changed, try `git fetch upstream && git merge upstream/master`

Stack trace:

#0      CiYaml._validate (package:cocoon_service/src/model/ci_yaml/ci_yaml.dart:395:7)
#1      new CiYaml (package:cocoon_service/src/model/ci_yaml/ci_yaml.dart:128:7)
#2      new CiYamlSet (package:cocoon_service/src/model/ci_yaml/ci_yaml.dart:48:23)
#3      CiYamlFetcher._getCiYaml (package:cocoon_service/src/service/scheduler/ci_yaml_fetcher.dart:124:12)
<asynchronous suspension>
#4      Scheduler.getPresubmitTargets (package:cocoon_service/src/service/scheduler.dart:1154:20)
<asynchronous suspension>
#5      Scheduler._getTestsForStage (package:cocoon_service/src/service/scheduler.dart:1484:14)
<asynchronous suspension>
#6      Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1525:30)
<asynchronous suspension>
#7      Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1634:7)
<asynchronous suspension>
#8      Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1419:5)
<asynchronous suspension>
#9      Scheduler.processBuildCompleted (package:cocoon_service/src/service/scheduler.dart:1360:11)
<asynchronous suspension>
#10     PresubmitSubscription._processBuild (package:cocoon_service/src/request_handlers/presubmit_subscription.dart:228:7)
<asynchronous suspension>
#11     PresubmitSubscription.post (package:cocoon_service/src/request_handlers/presubmit_subscription.dart:119:5)
<asynchronous suspension>
#12     RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:42:20)
<asynchronous suspension>
#13     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:134:5)
<asynchronous suspension>
#14     createServer.<anonymous closure> (package:cocoon_service/server.dart:462:7)
<asynchronous suspension>
#15     main.<anonymous closure>.<anonymous closure> (file:///app/app_dart/bin/gae_server.dart:192:9)
<asynchronous suspension>

@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Oct 27, 2026
@harryterkelsen harryterkelsen added the CICD Run CI/CD label Oct 27, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2026
@auto-submit

auto-submit Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/188628, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@MarlonJD

Copy link
Copy Markdown
Contributor Author

Google testing failed on the latest commit, while Dashboard Checks and flutter-gold passed. Could one of you check the internal failure and let me know whether this needs a change on my side or a rerun? Thanks!

@harryterkelsen

Copy link
Copy Markdown
Contributor

Sorry, this fell off my radar. The Google Testing failures look like flakes. I'll try re-running now

@harryterkelsen harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 29, 2026
Merged via the queue into flutter:master with commit d555faf Oct 30, 2026
31 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 30, 2026
jpohhhh pushed a commit to Telosnex/flutter that referenced this pull request Nov 5, 2026
Related: flutter#187660. Part 2 of 5, split from flutter#188628. This change can land
independently of the hybrid rasterizer.

Makes Skwasm callback IDs unique across surfaces and adds an explicit
bitmap-capture parameter to the native render call. Existing Dart
rendering still requests bitmaps; the new option allows a later onscreen
path to complete without clearing its backing canvas through bitmap
export.

Verified locally: Skwasm and Wimp native release builds;
overlapping-surface, context-loss and capture/no-capture tests in ST and
MT. The matching engine prebuilts must be available before dependent
Dart-only changes land.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant in-code documentation (doc comments with
`///`).
- [ ] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: zhongliugo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants