[CP-stable] Upgrade iOS version#188457
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled. |
There was a problem hiding this comment.
Code Review
This pull request updates the .ci.yaml configuration file to include iOS-26 in the device_os property and restricts the os property to Mac-15.7 across multiple test targets. The reviewer identified that iOS-26 is likely a non-existent version and suggested correcting it to a valid version like iOS-16 or iOS-17 to prevent CI/CD platform property matching failures.
| os: Mac-15.1|Mac-15.5|Mac-15.6|Mac-15.7 | ||
| device_os: iOS-18 | ||
| os: Mac-15.7 | ||
| device_os: iOS-18|iOS-26 |
| os: Mac-15.1|Mac-15.5|Mac-15.6|Mac-15.7 | ||
| cpu: x86 | ||
| device_os: iOS-18 | ||
| device_os: iOS-18|iOS-26 |
| os: Mac-15.1|Mac-15.5|Mac-15.6|Mac-15.7 | ||
| cpu: arm64 | ||
| device_os: iOS-18 | ||
| device_os: iOS-18|iOS-26 |
| task_name: flutter_gallery__transition_perf_e2e_ios | ||
| drone_dimensions: > | ||
| ["device_os=iOS-18","os=Mac-15.1|Mac-15.5|Mac-15.6|Mac-15.7", "cpu=x86"] | ||
| ["device_os=iOS-18|iOS-26","os=Mac-15.7", "cpu=x86"] |
Upgrade iOS version to use either iOS 18 or 26 *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* Fixes flutter#186090 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
5d0e3a6 to
55ccc98
Compare
|
autosubmit label was removed for flutter/flutter/188457, because - The status or check suite Mac_arm64 build_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
749881a to
ec61884
Compare
db3d82a
into
flutter:flutter-3.44-candidate.0
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#186090
Impact Description:
Updating CI to use either iOS 18 or 26 for easy transition when we update our devicelab bots
< Replace with impact description here >
Changelog Description:
Explain this cherry pick:
See best practices for examples.
< Replace with changelog description here >
[flutter/<ISSUE_NUMBER>] When [on <PLAFORMS(S)>],
Workaround:
Is there a workaround for this issue?
n/a
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
< Replace with validation steps here >