Skip to content

[CP-beta] No entitlements for snapshots (#188390)#188442

Merged
auto-submit[bot] merged 2 commits into
flutter:flutter-3.46-candidate.0from
LongCatIsLooong:cp-188390
Jun 23, 2026
Merged

[CP-beta] No entitlements for snapshots (#188390)#188442
auto-submit[bot] merged 2 commits into
flutter:flutter-3.46-candidate.0from
LongCatIsLooong:cp-188390

Conversation

@LongCatIsLooong

Copy link
Copy Markdown
Contributor

CP #188390 to unblock the 3.46 tree.

#188352 worked on the 3.45-candidate.0 branch:
https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=flutter-3.45-candidate.0 (so this should fix_ #188075 and unblock the beta release).

This is the same patch but with a mutual exclusivity check.

flutter#188352 worked on the
`3.45-candidate.0` branch:
https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=flutter-3.45-candidate.0
(so this should fix_ flutter#188075
and unblock the beta release).

This is the same patch but with a mutual exclusivity check.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 23, 2026
@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Jun 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request separates binaries and snapshots that do not require entitlements from those that do. It introduces new GN targets to generate lists of files without entitlements, updates the host artifacts and Dart SDK zip bundles to include these files, and updates the code-signing verification test accordingly. There are no review comments, and I have no feedback to provide.

@LongCatIsLooong LongCatIsLooong added the cp: review Cherry-picks in the review queue label Jun 23, 2026

@walley892 walley892 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend. Can you rebase?

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 23, 2026
@walley892 walley892 added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 23, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2026
@auto-submit

auto-submit Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/188442, because - The status or check suite Mac_arm64 build_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@walley892 walley892 added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2026
@auto-submit

auto-submit Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/188442, because - The status or check suite Windows windows_host_engine_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@LongCatIsLooong

LongCatIsLooong commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

autosubmit label was removed for flutter/flutter/188442, because - The status or check suite Windows windows_host_engine_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

This could be the same issue as #188182. Let's see if the rerun passes, if not I think #188186 might fix this.

@LongCatIsLooong

Copy link
Copy Markdown
Contributor Author

Phew Windows windows_host_engine_test finally passed after like 3 retries.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2026
@auto-submit
auto-submit Bot merged commit 300972d into flutter:flutter-3.46-candidate.0 Jun 23, 2026
179 checks passed
@LongCatIsLooong
LongCatIsLooong deleted the cp-188390 branch June 23, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD cp: review Cherry-picks in the review queue engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants