No entitlements for snapshots#188390
Merged
auto-submit[bot] merged 1 commit intoJun 23, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request separates binaries and Dart SDK snapshots that do not require entitlements from those that do, updating the build configurations and verification tests accordingly. A new without_entitlements.txt configuration is introduced to track these files. Feedback on the changes suggests correcting the assertion error message in BUILD.gn to accurately reference the variable names being compared.
Comment on lines
+231
to
+234
| assert( | ||
| filter_include(_dart_sdk_entitlement_contents, | ||
| _dart_sdk_without_entitlement_contents) == [], | ||
| "dart_sdk_without_entitlements and dart_sdk_entitlement_config contents must be mutually exclusive.") |
Contributor
There was a problem hiding this comment.
The assertion error message refers to dart_sdk_without_entitlements (which is not a defined variable or target name) and dart_sdk_entitlement_config (which is a target name, not the variable being compared). To make the error message more precise and useful, it should refer directly to the variable names being compared: _dart_sdk_entitlement_contents and _dart_sdk_without_entitlement_contents.
Suggested change
| assert( | |
| filter_include(_dart_sdk_entitlement_contents, | |
| _dart_sdk_without_entitlement_contents) == [], | |
| "dart_sdk_without_entitlements and dart_sdk_entitlement_config contents must be mutually exclusive.") | |
| assert( | |
| filter_include(_dart_sdk_entitlement_contents, | |
| _dart_sdk_without_entitlement_contents) == [], | |
| "_dart_sdk_entitlement_contents and _dart_sdk_without_entitlement_contents must be mutually exclusive.") |
References
- Error messages should be useful and accurate. Every error message is an opportunity to make someone love our product. (link)
vashworth
approved these changes
Jun 23, 2026
jason-simmons
approved these changes
Jun 23, 2026
LongCatIsLooong
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
auto-submit Bot
pushed a commit
that referenced
this pull request
Jun 23, 2026
CP #188390 to unblock the 3.46 tree. #188352 worked on the `3.45-candidate.0` branch: https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=flutter-3.45-candidate.0 (so this should fix_ #188075 and unblock the beta release). This is the same patch but with a mutual exclusivity check.
This was referenced Jun 24, 2026
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
flutter#188352 worked on the `3.45-candidate.0` branch: https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=flutter-3.45-candidate.0 (so this should fix_ flutter#188075 and unblock the beta release). This is the same patch but with a mutual exclusivity check. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This was referenced Jun 26, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 29, 2026
…12050) Manual roll requested by [email protected] flutter/flutter@11e339e...b081f33 2026-06-23 [email protected] No entitlements for snapshots (flutter/flutter#188390) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#188352 worked on the
3.45-candidate.0branch: https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=flutter-3.45-candidate.0 (so this should fix_ #188075 and unblock the beta release).This is the same patch but with a mutual exclusivity check.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.