Skip to content

Update docs for PR limits#188388

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
Piinks:PRLimits
Jun 23, 2026
Merged

Update docs for PR limits#188388
auto-submit[bot] merged 5 commits into
flutter:masterfrom
Piinks:PRLimits

Conversation

@Piinks

@Piinks Piinks commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This updates relevant contribution documentation with regards to the new Github PR limit feature.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 23, 2026
@github-actions github-actions Bot added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. d: docs/ flutter/flutter/docs, for contributors labels Jun 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a limit of two concurrent open pull requests for contributors without write access across public Flutter repositories, exempting draft pull requests and members of the 'flutter-hackers' group. The review feedback suggests simplifying redundant phrasing in the limit description and clarifying whether the limit applies per repository or across all repositories.

Comment thread CONTRIBUTING.md Outdated
Comment thread docs/contributing/Tree-hygiene.md Outdated
@Piinks
Piinks requested a review from stuartmorgan-g June 23, 2026 15:34
Piinks and others added 2 commits June 23, 2026 10:35
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 23, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 23, 2026
zanderso
zanderso previously approved these changes Jun 23, 2026
stuartmorgan-g
stuartmorgan-g previously approved these changes Jun 23, 2026

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

(Capturing here for future reference: I may need to adjust the plugin contribution instructions slightly in the future, because changing a federated plugin involves opening a sub-PR from the main PR, so people may end up in a situation where they have two distinct plugin PRs in progress, and are unable to open the sub-PR to proceed with getting one of them landed. I'll need to think about how we'll handle that; maybe just briefly making the main PR a draft.)

Comment thread docs/contributing/Tree-hygiene.md Outdated
Comment thread CONTRIBUTING.md Outdated
@Piinks
Piinks dismissed stale reviews from stuartmorgan-g and zanderso via 7bb3312 June 23, 2026 15:45
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 23, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 23, 2026
@Piinks
Piinks requested a review from stuartmorgan-g June 23, 2026 15:46
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2026
@bernaferrari

Copy link
Copy Markdown
Contributor

I have a question. If I become a "Dasher Emeritus" will I be restricted to only 2 PRs?

Merged via the queue into flutter:master with commit 9559214 Jun 23, 2026
25 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2026
@Piinks

Piinks commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

I have a question. If I become a "Dasher Emeritus" will I be restricted to only 2 PRs?

We are in the process of implementing the new contributor ladder now. Currently the PR limit feature does not support bypassing for specified teams/groups yet, but they will add this in the future. We will determine how that will apply once it becomes available and the new ladder is in place.

via-guy pushed a commit to via-guy/flutter that referenced this pull request Jun 26, 2026
This updates relevant contribution documentation with regards to the new
Github PR limit feature.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jun 29, 2026
…12041)

Manual roll requested by [email protected]

flutter/flutter@87224e0...11e339e

2026-06-23 [email protected] [flutter_tools] Migrate analysis_options.yaml to exclude build and platform directories by default (flutter/flutter#187940)
2026-06-23 [email protected] Update docs for PR limits (flutter/flutter#188388)
2026-06-23 [email protected] Roll Packages from cd5194a to 7d84a69 (4 revisions) (flutter/flutter#188383)
2026-06-23 [email protected] [Tool] Fix widget-preview crash by waiting for analysis server (flutter/flutter#187941)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. CICD Run CI/CD d: docs/ flutter/flutter/docs, for contributors framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants