It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Added a regression test in create_test.dart — has correct content and formatting with plugin template — that generates a plugin via flutter create -t plugin and asserts every generated .dart file is already dart format-clean. It mirrors the existing app template and module template formatting tests, and it guards against exactly this drift (it fails on the unformatted example app, passes with the fix). So this no longer relies on a test exemption.

autosubmit label was removed for flutter/flutter/188382, because - The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

• The status or check suite Linux tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

Thanks for the approvals @bkonyi @chingjun! Looks like autosubmit got removed because Mac_arm64 tool_tests_commands failed — the same suite is green on the Windows shards and the new test is platform-independent, so this looks like a flake. Could someone re-run that shard and re-add autosubmit once it's green? Thanks!

@theprantadutta it looks like this is a legitimate test failure in flutter/packages/flutter_tools/test/commands.shard/permeable/create_test.dart: has correct content and formatting with plugin template. There's some code that isn't formatted correctly and is causing a test expectation to fail.

You're right @bkonyi, thanks for catching that — and apologies for calling it a flake earlier. The new regression test caught a real leftover: the plugin's own generated test file. templates/plugin/test/projectName_test.dart.tmpl has

final {{pluginDartClass}}Platform initialPlatform = {{pluginDartClass}}Platform.instance;

which lands at 81 columns with the test's flutter_project name, so dart format wraps it. My earlier verification missed it because I had only format-checked example/ and used a shorter project name.

Fixed in 4291067 by dropping the redundant type annotation (final initialPlatform = {{pluginDartClass}}Platform.instance;) rather than pre-wrapping — a pre-wrapped line would get rejoined by the formatter for short plugin names, so keeping the line short for any realistic name is the only shape that works on both ends. Verified locally: flutter create -t plugin flutter_project → dart format --set-exit-if-changed across the entire project (not just example/) is clean, and the previously failing has correct content and formatting with plugin template test now passes.

One heads-up while verifying: with very short names (e.g. abc) two pre-existing pre-wrapped constructs still collapse (class Mock{{pluginDartClass}}Platform with ... implements ... in this same file, and the ?? 'Unknown platform version' wrap in the example) — that's inherent to name-length-dependent wrapping and exists on master today, so I left it alone; happy to file a follow-up issue if it's worth tracking.

@theprantadutta there still appears to be formatting issues that are causing test failures.

Thanks for the ping @bkonyi — root-caused it from the LUCI log. The master merge rolled in a newer formatter that now separates dart:/package: import sections with a blank line, and the plugin-hook block in main.dart.tmpl was generating import 'dart:async'; directly under the material import, so the example's main.dart stopped being format-clean. Fixed in 1085413 by adding the blank line in the template (both the platform-channel and ffi variants — the template sections render adjacent to the shared material import). The rendered output now matches the formatter's own output from the failing run byte-for-byte, so the plugin template test should go green on the next CI run.